-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autocomplete icon #209
Conversation
@hanzei The icon seems to have a white background within the image which is inconsistent with the rest of the plugins. Can we replace the icon with the attached file? |
@abhijit-singh E.g. |
Agreed. I can see why it's almost necessary with Github, unless we solve it algorithmically, which I feel is ideal. I'll create a ticket for myself to come up with a logic that works, till then can we take a call on a case-by-case basis? |
@abhijit-singh Sure 👍 It seems like the file you send above (https://user-images.githubusercontent.com/14369607/107503207-ae2c5a80-6bbf-11eb-9905-a8def040f187.png) also contains a background. Could you please double check? |
@hanzei The file is transparent if you download it and check. It seems like the browser is adding that background colour for some reason. |
@abhijit-singh Yes, that seems to be added by my browser. Could you please provide the image as an |
@abhijit-singh Thanks for the updated image. I've updated the screenshot. Please take another look. |
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
==========================================
- Coverage 23.25% 23.21% -0.05%
==========================================
Files 64 64
Lines 2313 2317 +4
==========================================
Hits 538 538
- Misses 1695 1699 +4
Partials 80 80
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Autocomplete icon appears as expected
- Confirmed that icon appears as expected and there is no light background visible on dark themes
- Icon appears for all sub-commands
LGTM!
Summary
Ticket Link
Fixes #191