Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release bump to v1.1.0 #213

Merged
merged 5 commits into from
Oct 4, 2021
Merged

Release bump to v1.1.0 #213

merged 5 commits into from
Oct 4, 2021

Conversation

mickmister
Copy link
Contributor

Summary

Bump mscalendar plugin to v1.1.0

Improvements

b8aff5a Implement autorespond feature (#188)
596cad1 Add Autocomplete icon (#209)
19d0766 Fix autocomplete terms and help text to match available commands (#200)
5798bf3 Add Fallback to Slack Attachments (#183)
b952d3c [GH-125] Remember user last status on status change (#140)
3a6d0e7 Improve message on login flow for receiving notifications during meetings (#158)
61581f3 Use limit 20 for calendar events API call (#178)
5c6f67e Add Telemetry to MSCalendar (#152)
c0d915f Order daily summary view (#177)
3e459f7 Update license to Source Available license (#182)
e05112b Drop "E20 only" from plugin name (#208)

Fixes

a488054 Fix panic when Daily Summary is nil for a user (#199)
50beb11 When trying to renew an expired subscription, create new subscription instead (#131)
26fe3c5 use api for license and fix tests (#195)
b8de849 Update system admin check in api.go (#197)
62dad6e Update how to fetch diagnostic id to avoid panics (#187)

Maintenance

8437af7 Update README.md (#190)
45c98fd Update plugin.json (#207)
5e9b8e3 Bump lodash from 4.17.11 to 4.17.20 in /webapp (#185)
d10dbd4 Bump elliptic from 6.5.0 to 6.5.3 in /webapp (#186)
47245b0 Bump ini from 1.3.5 to 1.3.8 in /webapp (#201)
4a9daba Issue-184/integrate-golanglint-only (#196)
c751170 Add release_notes_url (#193)
aee00cc go mod tidy (#212)
5cb1e2a Bump elliptic from 6.5.3 to 6.5.4 in /webapp (#211) (showing up twice here)

@mickmister mickmister added 2: Dev Review Requires review by a core committer 1: PM Review Requires review by a product manager 3: QA Review Requires review by a QA tester labels Mar 19, 2021
plugin.json Outdated Show resolved Hide resolved
@mickmister mickmister requested a review from hanzei March 24, 2021 14:40
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 25, 2021
@DHaussermann
Copy link

/update-branch

@mattermod
Copy link
Contributor

Error trying to update the PR.
Please do it manually.

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #213 (8105f26) into master (cd90e1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   23.80%   23.80%           
=======================================
  Files          62       62           
  Lines        2541     2541           
=======================================
  Hits          605      605           
  Misses       1857     1857           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd90e1b...8105f26. Read the comment docs.

@DHaussermann
Copy link

/update-branch

Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Ran through release tests
    • Status changes happen as expected in appropriate scenarios
    • All settings on the config panel work as expected
    • Subscriptions, Event reminders and Status change notifications work as expected
    • Summary report functionality is working as expected
  • Confirmed new license SKUs work as expected
  • As a precaution - tested that Sync and Summary jobs work normally in HA.
  • Confirmed version bumped to v1.1.0

One last question on this... Seems the build hash no longer shows in the info command.
image
@hanzei I believe this is related to build tooling. Do you happen to know if this should still be showing here?

@mickmister
Copy link
Contributor Author

@hanzei Does @DHaussermann's comment above need to be resolved before this is merged?

@DHaussermann
Copy link

@mickmister one more question here - there are 2 error that occur when running the full make. These errors also occur on master branch so, it's more a question if they must be solved before release.

go install github.com/golang/mock/mockgen
../../../../pkg/mod/github.com/golang/mock@v1.4.4/mockgen/parse.go:35:2: missing go.sum entry for module providing package golang.org/x/tools/go/packages (imported by github.com/golang/mock/mockgen); to add:
	go get github.com/golang/mock/mockgen@v1.4.4
make: *** [mock] Error 1

and

Running golangci-lint
golangci-lint run ./...
gomock_reflect_459867974/prog.go:64:3: exitAfterDefer: os.Exit clutters `defer func(){...}(...)` (gocritic)
		os.Exit(1)
		^
gomock_reflect_459867974/prog.go:1: File is not `gofmt`-ed with `-s` (gofmt)

make: *** [golangci-lint] Error 1

@mickmister
Copy link
Contributor Author

mickmister commented Sep 22, 2021

@hanzei Can this be merged with the issue described above?

Edit: Whoops I meant just the "missing build number" error. I'm working on fixing the last error above

@hanzei
Copy link
Collaborator

hanzei commented Sep 27, 2021

I'm fine with cutting this release even if the build number issue isn't fixed yet.

@hanzei hanzei added this to the v1.1.0 milestone Sep 29, 2021
@hanzei hanzei requested a review from DHaussermann September 29, 2021 19:28
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Release testing done based on comment above
  • Verified version stamp fix
  • No further testing needed

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 1: PM Review Requires review by a product manager 3: QA Review Requires review by a QA tester labels Oct 3, 2021
@mickmister mickmister merged commit 9411708 into master Oct 4, 2021
@mickmister mickmister deleted the release-bump-v1.1.0 branch October 4, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants