Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-461] Handle case of very long title and label in RHS #510

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[GH-461] Handle case of very long title and label in RHS #510

merged 3 commits into from
Nov 22, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

  • Handle case of very long title and label in RHS

Screenshot:

image
image

How to test?

  1. Connect your Gitlab account.
  2. Create a issue/PR with very long title/label and assign it to yourself.
  3. Open the RHS of plugin.

Ticket Link

Fixes #461

@raghavaggarwal2308 raghavaggarwal2308 self-assigned this Jul 17, 2024
ayusht2810
ayusht2810 reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@ayusht2810 ayusht2810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we tested this while we expand the rhs or in different resolutions?

@wiggin77 wiggin77 added the 3: QA Review Requires review by a QA tester label Jul 31, 2024
@raghavaggarwal2308 raghavaggarwal2308 added this to the v1.10.0 milestone Nov 22, 2024
arush-vashishtha
arush-vashishtha approved these changes Nov 22, 2024
View reviewed changes
Copy link

@arush-vashishtha arush-vashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been tested and the long titles and long labels are looking fine in both RHS and expanded RHS. LGTM

@raghavaggarwal2308 raghavaggarwal2308 added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Nov 22, 2024
@raghavaggarwal2308 raghavaggarwal2308 merged commit a99bfb1 into master Nov 22, 2024
7 checks passed
@raghavaggarwal2308 raghavaggarwal2308 deleted the MM-461 branch November 22, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arush-vashishtha arush-vashishtha arush-vashishtha approved these changes

@ayusht2810 ayusht2810 ayusht2810 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@mickmister mickmister Awaiting requested review from mickmister

@spirosoik spirosoik Awaiting requested review from spirosoik spirosoik is a code owner

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@raghavaggarwal2308 raghavaggarwal2308

Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Handle case for RHS when there is very long title/label name in a PR/issue
4 participants
@raghavaggarwal2308 @wiggin77 @ayusht2810 @arush-vashishtha