Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-461] Handle case of very long title and label in RHS #510

Merged
merged 3 commits into from
Nov 22, 2024
Merged

[GH-461] Handle case of very long title and label in RHS #510

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02f5084
[GH-461] Handle case of very long title and label in RHS
raghavaggarwal2308 Jul 17, 2024
69c6e94
[MM-672] Review fix
raghavaggarwal2308 Aug 9, 2024
5929cb0
[MM-672] Fix lint error
raghavaggarwal2308 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 27 additions & 14 deletions webapp/src/components/sidebar_right/gitlab_items.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ export const notificationReasons: Record<string | symbol, string> = {
const SUCCESS = 'success';
const PENDING = 'pending';
const ACTION_NAME_MEMBER_ACCESS_REQUESTED = 'member_access_requested';
const MAX_TITLE_LENGTH = 100;
const MAX_LABEL_LENGTH = 20;

function GitlabItems({item, theme}: GitlabItemsProps) {
const style = getStyle(theme);
Expand All @@ -50,8 +52,8 @@ function GitlabItems({item, theme}: GitlabItemsProps) {
);
}

const titleText = item.title || item.target?.title || item.body || '';

let titleText = item.title || item.target?.title || item.body || '';
titleText = titleText.length > MAX_TITLE_LENGTH ? `${titleText.substring(0, MAX_TITLE_LENGTH)}...` : titleText;
let title: React.ReactNode = titleText;
if (item.web_url || item.target_url) {
title = (
Expand Down Expand Up @@ -258,28 +260,39 @@ const getStyle = makeStyleFromTheme((theme) => {
const getGitlabLabels = (labels: Label[]) => {
return labels.map((label) => {
return (
<Badge
key={label.id}
style={{
...itemStyle,
...{
backgroundColor: `${label.color}`,
color: `${label.text_color}`,
},
}}
<OverlayTrigger
key='labelName'
placement='top'
overlay={
<Tooltip id='labelName'>
{label.name}
</Tooltip>
}
>
{label.name}
</Badge>
<Badge
key={label.id}
style={{
...labelStyle,
...{
backgroundColor: `${label.color}`,
color: `${label.text_color}`,
},
}}
>
{label.name.length > MAX_LABEL_LENGTH ? `${label.name.substring(0, MAX_LABEL_LENGTH)}...` : label.name}
</Badge>
</OverlayTrigger>
);
});
};

const itemStyle: CSS.Properties = {
const labelStyle: CSS.Properties = {
margin: '4px 5px 0 0',
padding: '3px 8px',
display: 'inline-flex',
borderRadius: '3px',
position: 'relative',
justifyContent: 'flex-start',
};

export default GitlabItems;
Loading