Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing sprintf placeholder #1339

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add missing sprintf placeholder #1339

merged 1 commit into from
Jan 5, 2021

Conversation

fbourigault
Copy link
Contributor

Q A
Branch? 2.0
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Found with PHPStan (#1336).

@lsmith77
Copy link
Contributor

lsmith77 commented Jan 5, 2021

there seems to be a build failure here?

@fbourigault
Copy link
Contributor Author

The failure looks weird to me. Do you have some retry button in the Actions/Checks tabs?

@lsmith77 lsmith77 changed the base branch from master to 2.x January 5, 2021 12:48
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.645% when pulling 3e40ce0 on fbourigault:missing-sprintf-placeholder into dcf8300 on liip:2.x.

@lsmith77 lsmith77 merged commit ece80b3 into liip:2.x Jan 5, 2021
@fbourigault fbourigault deleted the missing-sprintf-placeholder branch January 5, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @lsmith77 @coveralls