-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run static code analysis on GitHub Actions #1336
Conversation
With current implementation, phpstan can be installed with a newer version in an unrelated PR. This could lead to unrelated build failures. What are our options to lock phpstan to a given version? EDIT: |
there seems to be a minor conflict. |
for a sub 1.0 dependency on a require-dev I am totally fine locking for a specific version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the late reply. looks good to me, thanks a lot for the work! didn't know about the phpstan stub functionality, that is quite neat (i always made it ignore the warnings about unknown classes, with a comment that this was legacy support. much better and safer with the stubs thing!)
i will rebase the branch to solve conflicts and then merge.
thanks! i rebased and solved conflicts in #1390 but unfortunately a couple of failures now show |
As discussed with @dbu, here is a PR to replace most of Scrutinizer work with static code analysis.
I choose PHPStan as I use it daily at work and it's the tool used by SonataAdminBundle which is my main source of inspiration for all my GitHub Actions PRs.