Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not force snapshot tree too early #5752

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: do not force snapshot tree too early #5752

merged 1 commit into from
Oct 17, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Oct 17, 2024

This turns out to be the issue behind #5736, though really it is yet another indicator of a general thread pool weakness.

@Kha Kha enabled auto-merge October 17, 2024 12:13
@Kha Kha added this pull request to the merge queue Oct 17, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 17, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 17, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5752
57ff3f5
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 17, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5752
3fd3253
Merged via the queue into leanprover:master with commit fc5e3cc Oct 17, 2024
14 checks passed
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 17, 2024
@Kha Kha deleted the push-oqtvnmouzxxp branch October 17, 2024 16:14
github-actions bot pushed a commit that referenced this pull request Oct 21, 2024
@Kha @github-actions
fix: do not force snapshot tree too early (#5752)
33b3f84 
This turns out to be the issue behind #5736, though really it is yet
another indicator of a general thread pool weakness.

(cherry picked from commit fc5e3cc)
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Merged
kim-em pushed a commit that referenced this pull request Oct 21, 2024
@Kha @kim-em
fix: do not force snapshot tree too early (#5752)
480d731 
This turns out to be the issue behind #5736, though really it is yet
another indicator of a general thread pool weakness.

(cherry picked from commit fc5e3cc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.13.0 builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kha @leanprover-community-bot @kim-em