fix: don't block on snapshot tree if tracing is not enabled #5736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-releases/v4.13.0 releases/v4.13.0
# Navigate to the new working tree
cd .worktrees/backport-releases/v4.13.0
# Create a new branch
git switch --create backport-5736-to-releases/v4.13.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 79583d63f3231f0b5c84922292908d7405309486
# Push it to GitHub
git push --set-upstream origin backport-5736-to-releases/v4.13.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-releases/v4.13.0Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
While there appears to be an underlying issue of blocking tasks that this specific PR is not resolving, it should alleviate the problems described in https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/reliable.20file.20desync.20on.20Linux.20Mint as it effectively reverts the relevant change introduced in 4.13.0-rc1 when the trace option is not set. (cherry picked from commit 79583d6)
kim-em
pushed a commit
that referenced
this pull request
Oct 17, 2024
While there appears to be an underlying issue of blocking tasks that this specific PR is not resolving, it should alleviate the problems described in https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/reliable.20file.20desync.20on.20Linux.20Mint as it effectively reverts the relevant change introduced in 4.13.0-rc1 when the trace option is not set. (cherry picked from commit 79583d6)
Kha
added a commit
to Kha/lean4
that referenced
this pull request
Oct 17, 2024
…er#5736) While there appears to be an underlying issue of blocking tasks that this specific PR is not resolving, it should alleviate the problems described in https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/reliable.20file.20desync.20on.20Linux.20Mint as it effectively reverts the relevant change introduced in 4.13.0-rc1 when the trace option is not set. (cherry picked from commit 79583d6)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
This turns out to be the issue behind #5736, though really it is yet another indicator of a general thread pool weakness.
kim-em
pushed a commit
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there appears to be an underlying issue of blocking tasks that this specific PR is not resolving, it should alleviate the problems described in https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/reliable.20file.20desync.20on.20Linux.20Mint as it effectively reverts the relevant change introduced in 4.13.0-rc1 when the trace option is not set.