Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KTOR-8043 Add retry to server tests by default #4593

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Jan 10, 2025

Subsystem
Test infrastructure

Motivation
KTOR-8043 Retry server tests one time by default

Solution

  • Use multi-platform retryTest function implemented for client tests before.
  • Commonize posix and wasmJsAndJs implementation of BaseTest

@osipxd osipxd self-assigned this Jan 10, 2025
@osipxd osipxd marked this pull request as ready for review January 10, 2025 12:35
@osipxd osipxd requested a review from e5l January 10, 2025 12:35
@osipxd osipxd force-pushed the osipxd/retry-server-tests branch 2 times, most recently from e7c9218 to 915ca25 Compare January 10, 2025 14:07
@osipxd osipxd force-pushed the osipxd/retry-server-tests branch from 915ca25 to 70d6a51 Compare January 10, 2025 14:09
@osipxd osipxd changed the title KTOR-8043 Retry server tests one time by default KTOR-8043 Add retry to server tests by default Jan 10, 2025
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm

@osipxd osipxd merged commit 92025f5 into main Jan 13, 2025
16 checks passed
@osipxd osipxd deleted the osipxd/retry-server-tests branch January 13, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants