Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcurl to 8.11.1 with enabled websockets #4588

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Jan 9, 2025

Subsystem
ktor-client-curl

Motivation
Prerequisite for #3950 (requested in #4445 (comment))

Solution
use libcurl conan recipe from conan-io/conan-center-index#25880 to have latest libcurl with enabled websockets
Build link with artifacts: /~https://github.com/whyoleg/openssl-builds/actions/runs/12408102489

Tested, that at least some of the tests on macosArm64 for curl are working from #3950, so built libcurl is definitely supports web sockets:
image

Copy link
Member

@osipxd osipxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! 🥇
I'll merge it after the PR adding retries for server tests get merged: #4593

@osipxd osipxd enabled auto-merge (squash) January 13, 2025 08:37
@osipxd osipxd merged commit 4da9f59 into ktorio:main Jan 13, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants