-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Socket.io to 1.7.4 to avoid issue with ws@1.1.2 #2744
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
Trying the Google CLA process again... |
CLAs look good, thanks! |
@creat-or any additional changes required for this to be merged and released? |
Yeah, it has no sense that I approved it, since I have no write privileges on this repository. I just can't wait that this will be merged ;) |
Could somebody please review and merge that fix? It's really small and has a lot of impact ;) |
The issue why this was not updated before is that there were breaking changes in socket.io before regarding ie7. Does someone have insight into the state of this? |
Do you mean this one? socketio/socket.io-client#1099 ... doesn't seem like much activity on this side. |
Alright I'll take a look at merging things later tonight |
Can we have minor version release with this fixed? I believe a lot of people are having this issue and it would be great to have this fixed in npm instead of patching it manually. |
I'd also like a minor release with this. I can patch my dev environment, but my Travis karma tests have been failing and probably will continue to until I can ref a release with this fix. |
See #2593