Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Contributors #2474

Open
dignifiedquire opened this issue Nov 28, 2016 · 43 comments
Open

Call for Contributors #2474

dignifiedquire opened this issue Nov 28, 2016 · 43 comments

Comments

@dignifiedquire
Copy link
Member

dignifiedquire commented Nov 28, 2016

As you might have noticed, I'm struggling to maintain all of the karma eco system. This is why I am asking today for your help. If you want to help, please leave comment here so we can get talking. The things that need help the most are

Issues & Support

  • Adding labels to issues
  • Responding and asking for more feedback
  • Closing outdated and solved issues
  • Responding to support and help questions on the issue tracker and stack overflow
  • Figuring out if gitter is good or if we should have another support channel
  • Investigating issues that have the needs: investigation label. Those need confirmation that it is a bug or if it is a support issue.

Documentation & Website

The documentation is pretty good, but needs updates and additions

Code

  • Lots of bugs and features that are waiting to be implemented on the issue tracker :)

Future work

I would like to start discussions around major pain points and improvements in the user experience for karma users. Especially with lessons lerned from tools like Jest and Ava. But also looking to other great testing tools like pytest

Maintaining

I can maintain the main repo, but for the many plugins I need help, especially as there are often for tools I don't use or have good experience with.
The major ones are

  • karma-slimerjs-launcher
  • karma-coffee-preprocessor
  • karma-script-launcher
  • karma-dart
  • karma-opera-launcher
  • karma-phantomjs-launcher
  • karma-mocha
  • karma-teamcity-reporter
  • karma-coverage
  • karma-chrome-launcher
  • karma-requirejs
  • karma-ng-html2js-preprocessor
  • karma-junit-reporter
  • karma-browserstack-launcher
  • karma-closure
  • karma-ng-scenario
  • karma-googmodule-preprocessor
  • karma-commonjs
  • karma-dojo
  • karma-firefox-launcher
  • karma-sauce-launcher
  • karma-jasmine
  • karma-webdriver-launcher
  • karma-ie-launcher
  • karma-safari-launcher
  • karma-growl-reporter
  • karma-ember-preprocessor
  • karma-cli
  • karma-intellij
  • maven-karma-plugin
  • karma-traceur-preprocessor
  • karma-nodeunit
  • karma-tyrtle

Karma is an awesome project, but to get it to the next level I will need your help to achieve it.

@vivganes
Copy link
Contributor

@dignifiedquire I am very much willing to contribute!

Tell me how I can help :)

@dignifiedquire
Copy link
Member Author

I am very much willing to contribute!

Awesome, from the areas listed above, are there specific things you would like to work on?

@dhoinka
Copy link

dhoinka commented Nov 28, 2016

I would like to help ... preferably I would like to fix bugs if you could point me in a direction

@dignifiedquire
Copy link
Member Author

dignifiedquire commented Nov 28, 2016

I would like to help ... preferably I would like to fix bugs if you could point me in a direction

Great, you can start by looking at this list:

@kostkobv
Copy link

@dignifiedquire I would like to contribute as well

@tiagomsmagalhaes
Copy link

tiagomsmagalhaes commented Nov 28, 2016

@dignifiedquire I would like to contribute, but at a glance it seems overwhelming for me... I have professional experience with AngularJS and exploring E2E testing with Protractor (and some shallow exploration of webdriver), I hope this info is good enough to provide some guidance..

@boneskull
Copy link
Contributor

As much as I'd love to offer to take over maintenance of karma-mocha, we barely have enough resources to manage our own code.

At the risk of broaching a sensitive subject...

All these projects are copyright Google? Users must sign a CLA to contribute. Google's CLA is not particularly friendly to contributions by 3rd-party employees (or anyone except Google, really). This means fewer contributions, of course. Node.js dropped its CLA for similar reasons.

Does Google still "own" this project? Isn't it used by the Angular team? Where are the internal resources?

@dignifiedquire Are you a Google employee? Perhaps you can provide some insight?

@vivganes
Copy link
Contributor

@dignifiedquire I would love to take up improvements in the following areas:

  • Documentation and Website
  • karma-intellij

I will also help in triaging issues.

Awesome, from the areas listed above, are there specific things you would like to work on?

@jeserkin
Copy link

@dignifiedquire if help is still required, then count me in!

I'm using Karma on a daily basis, so I'm very interested in projects well-being.

@dignifiedquire
Copy link
Member Author

I would like to contribute, but at a glance it seems overwhelming for me

@tiagomsmagalhaes I will try to start labeling issues with difficulty to help with that. In the meantime things like going through the documentation and making sure things are up to date should give you a good way to learn your way around.

@dignifiedquire
Copy link
Member Author

@vivganes added you to the main repo and karma-intellij

@dignifiedquire
Copy link
Member Author

if help is still required, then count me in!

@jeserkin we have enough work for everyone :)

Anything in particular you would like to start working on?

@dignifiedquire
Copy link
Member Author

@boneskull I am not a Google employee, but @vojtajina the original author of karma was when he wrote the project which is the reason it is still under the Google umbrella right now. I'm talking to them about changing this, but I don't know if and how fast things in this area will change.

@dignifiedquire
Copy link
Member Author

I would like to contribute as well

@kostkobv great, anything in particular you would like to start working on?

@jeserkin
Copy link

jeserkin commented Nov 29, 2016

@dignifiedquire I think closest topics to me are:

  • karma-phantomjs-launcher
  • karma-mocha
  • karma-jasmine

Plus labeling issues or requesting more information.

@kostkobv
Copy link

@dignifiedquire I would like to work with karma-mocha, karma-jasmine and karma-phantomjs-launcher for the same reason as @dignifiedquire.

Still I'm open to assist with any kind of issues on any plugin

@dignifiedquire
Copy link
Member Author

@jeserkin @kostkobv added you to those three repos.

For everyone I have given write access: Please no merges without review of at least one other contributor, and on karma itself no merges without my approval. Also no pushes to master please.
Also please keep your work to personal forks rather for now. Thank you 🎉

@boneskull
Copy link
Contributor

@dignifiedquire Hmm. Are they just no longer interested in Karma?

@wesleycho
Copy link
Member

I would like to assist as well - in particular, I would like to assist with the core, and maybe other plugins. In particular, I (selfishly) would like to work on whatever is necessary to implement support for headless Chrome, as I've been bitten more than once by PhantomJS (including today) :) , but I also am willing to work on any other task needed too.

Is there a gathering point for people to discuss strategy, i.e. what issues to address first, things that should be changed when, etc.? Such a chatroom would also be useful for being relayed information quicker. I investigated some of the issues earlier this year, some of them eluded me when I was trying to work on them individually, and I ended up running out of time due to traveling a lot & being promoted to a tech lead/engineering manager. My time is starting to free up a little more though, so I am looking to get involved with open source more again.

@jeserkin
Copy link

jeserkin commented Dec 2, 2016

Regarding @wesleycho second paragraph. I've also thought about a way to discuss quickly some questions. There are different ways for it. Gitter, Slack, Skype, SO Private chat room. Those who take part in managing karma-runner repos should probably vote and decide. What do you think guys?

@hiroppy
Copy link

hiroppy commented Dec 3, 2016

@dignifiedquire I would be willing to help with contributing karma-cli:)

@dignifiedquire
Copy link
Member Author

@wesleycho added you to the main repo, so you can add labels.

@everyone I appreciate all the feedback and work already being done. Thank you!

@dignifiedquire
Copy link
Member Author

@dignifiedquire
Copy link
Member Author

@abouthiroppy great, it really needs some love =)

@krotscheck
Copy link
Contributor

Hrm- I wouldn't mind helping with karma-browserstack-launcher. It's not a huge codebase to maintain, and we use it at work.

@dignifiedquire
Copy link
Member Author

@krotscheck great to hear :)

@gsuresh86
Copy link

I would like to contribute to the website. Here is my first pull request
karma-runner/karma-runner.github.com#40

@luchillo17
Copy link

@dignifiedquire I would like to help but first i have to make work karma in my project.

Basically a Node api, with webpack, typescript, karma, jasmine, and trying to integrate karma-coverage, until that happens i'll be of no use.

@valera-rozuvan
Copy link

@dignifiedquire I want to help. Code, documentation, project management, issues & bugs, etc.

@luchillo17
Copy link

Hey @dignifiedquire i actually managed to get through it, i have a current Node.js app running on karma, jasmine and typescript with karma coverage on, wanna take a look?

Although i need to updated since the real project in which i have it working is in Bitbucket in a privated repo: Luchillo/Node-typescript-karma-base

@gcca
Copy link

gcca commented Mar 2, 2017

I would like contribute, @dignifiedquire. I could help in Issues & Support, and Coding.

@rogeriopvl
Copy link
Contributor

@dignifiedquire I can help with karma-chrome-launcher & karma-cli

@dignifiedquire
Copy link
Member Author

@gcca @rogeriopvl great to hear :) feel free to start responding to issues and making PRs for fixes :)

@rogeriopvl
Copy link
Contributor

@dignifiedquire already did a PR and checked some issues, but it would be easier if you add me to the repo/org so I can starting labelling and cleaning stuff.

@guilhermejcgois
Copy link

Hey @dignifiedquire , I have installed the karma@latest from npm, and it come with version 1.7.3 of socket.io. At work we're having problems to run ours test and probably that update can solve our problem. I've noticed come people with some type of problem with socket.io dep in #2777 #2735, some PRs about it #2744 #2821 and I've reported something like in august at #2798. Can I try to do something for help?

@EzraBrooks
Copy link
Collaborator

@dignifiedquire I’d like to contribute to issue management, the backlog here is tremendous.

@dignifiedquire
Copy link
Member Author

Thanks @EzraBrooks for the help. Getting through this backlog would be great! I just added you as a collaborator to the repo.

@UniverseHan
Copy link

I wanna join too

@lusarz
Copy link
Contributor

lusarz commented Feb 25, 2018

@dignifiedquire I'd like to contribute as well.

@Johann-S
Copy link

@dignifiedquire I can help you on karma-qunit if you want 😉

@Krinkle
Copy link
Contributor

Krinkle commented Aug 21, 2018

@dignifiedquire hereby volunteering to help with karma-runner/karma-qunit (on behalf of @qunitjs), and also with karma-runner/grunt-karma (on behalf of Wikimedia).

@johnjbarton
Copy link
Contributor

@Krinkle I added you to these projects. karma-qunit is in pretty good shape if the recent PRs land. grunt-karma could use some love.

@AaronNGray
Copy link

AaronNGray commented Jan 8, 2020

@dignifiedquire I have investigated doing development time security fixes as I need to use karma. Also I want to try and get the IE11 karma-ie-launcher fixed, as its failing to run properly.

There are loads of issues with handlebars under istanbul for both karma-typescript and karma-coverage. The issue is istanbul has been frozen and also has many many more development time security issues that this npm audit does not find.

There is a new cli replacement for istanbul called nyc.

I have made a minor pull request to istanbul hoping they will take it.

gotwarlost/istanbul#924

Heres an audit of a test project :-

/~https://github.com/AaronNGray/karma-typescript-mocha-chai-sinon-es6-modules

C:\Users\aaron\Examples\TypeScript\karma-typescript-mocha-chai-sinon-es6-modules>npm audit

                       === npm audit security report ===


                                 Manual Review
             Some vulnerabilities require your attention to resolve

          Visit https://go.npm.me/audit-guide for additional guidance


  Critical        Prototype Pollution

  Package         handlebars

  Patched in      >=4.0.14 <4.1.0 || >=4.1.2

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/755


  Critical        Prototype Pollution

  Package         handlebars

  Patched in      >=4.0.14 <4.1.0 || >=4.1.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/755


  Critical        Prototype Pollution

  Package         handlebars

  Patched in      >=4.0.14 <4.1.0 || >=4.1.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/755


  Critical        Prototype Pollution

  Package         handlebars

  Patched in      >=4.0.14 <4.1.0 || >=4.1.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/755


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.3.0

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1164


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.3.0

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1164


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.3.0

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/1164


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.3.0

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/1164


  Moderate        Denial of Service

  Package         handlebars

  Patched in      >=4.4.5

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1300


  Moderate        Denial of Service

  Package         handlebars

  Patched in      >=4.4.5

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1300


  Moderate        Denial of Service

  Package         handlebars

  Patched in      >=4.4.5

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/1300


  Moderate        Denial of Service

  Package         handlebars

  Patched in      >=4.4.5

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/1300


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.2

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1316


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1316


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/1316


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.2

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/1316


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1324


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1324


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/1324


  High            Arbitrary Code Execution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/1324


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-coverage [dev]

  Path            karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1325


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > karma-coverage > istanbul > handlebars

  More info       https://npmjs.com/advisories/1325


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > istanbul > handlebars

  More info       https://npmjs.com/advisories/1325


  High            Prototype Pollution

  Package         handlebars

  Patched in      >=4.5.3

  Dependency of   karma-typescript [dev]

  Path            karma-typescript > remap-istanbul > istanbul > handlebars

  More info       https://npmjs.com/advisories/1325

found 24 vulnerabilities (4 moderate, 16 high, 4 critical) in 4296 scanned packages
  24 vulnerabilities require manual review. See the full report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests