Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean-up]: Remove deprecated plexus/DirectedGraph #2548

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

hari45678
Copy link
Contributor

@hari45678 hari45678 commented Jan 5, 2025

Which problem is this PR solving?

Description of the changes

  • This PR removes the DirectedGraph component from plexus lib. The component was anyway looking ugly on demos (big arrows), which might be due to the fact that it stopped receiving changes.

How was this change tested?

  • npm run start in plexus package.

Checklist

Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
@hari45678 hari45678 requested a review from a team as a code owner January 5, 2025 07:43
@hari45678 hari45678 requested review from pavolloffay and removed request for a team January 5, 2025 07:43
Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (355758b) to head (d45e161).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2548   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files         255      255           
  Lines        7728     7728           
  Branches     1950     1950           
=======================================
  Hits         7468     7468           
  Misses        260      260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hari45678
Copy link
Contributor Author

A new version of plexus can also be published to npmjs

Steps:

  • Change the version in plexus/package.json to 0.3.0 (for a minor up).
  • run npm run build
  • npm login
  • npm publish
  • done

hari45678 and others added 2 commits January 6, 2025 10:42
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
@hari45678
Copy link
Contributor Author

I have changed the demos to align with Digraph props and types.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jan 6, 2025
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 885eaea into jaegertracing:main Jan 6, 2025
8 of 9 checks passed
@hari45678 hari45678 deleted the plex-diag branch January 7, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants