Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated plexus/DirectedGraph #1940

Closed

Conversation

yurishkuro
Copy link
Member

Hard to tell what was the intention/distinction between plexus/Digraph and plexus/DirectedGraph, but there seemed to be an intention to remove it:

  • the latter is not used anywhere in jaeger-ui or internally in plexus (other than being exported)
  • the history log shows changes by @tiffon to DirectedGraph stopped but changes to Digraph continued
  • there are comments in several places "Update import after killing DirectedGraph"

Open issue: plexus/demo does use DirectedGraph

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner November 3, 2023 01:28
@yurishkuro yurishkuro requested review from joe-elliott and removed request for a team November 3, 2023 01:28
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (25d13e3) to head (29b9651).
Report is 311 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1940   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         256      256           
  Lines        7600     7600           
  Branches     1976     1976           
=======================================
  Hits         7332     7332           
  Misses        268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member Author

@hari45678 would you like to revisit and finish this one?

@hari45678
Copy link
Contributor

@hari45678 would you like to revisit and finish this one?

Sure. would look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants