Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass realpath(process.cwd()) to test-exclude #8

Merged
merged 1 commit into from
Jul 3, 2016

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Jul 1, 2016

This is a fix for #7.

@bcoe
Copy link
Member

bcoe commented Jul 1, 2016

@motiz88 looks like you might have bit by standard formatting nits.

@coveralls
Copy link

coveralls commented Jul 2, 2016

Coverage Status

Coverage remained the same at 94.444% when pulling ec76083 on motiz88:cwd-realpath into 320c3df on istanbuljs:master.

@motiz88
Copy link
Contributor Author

motiz88 commented Jul 2, 2016

Oops! Right. I've now force-pushed an edited commit.

@bcoe
Copy link
Member

bcoe commented Jul 2, 2016

@motiz88 looks good, I'll test this against some of my projects. This fixed the problem for you on your project?

@motiz88
Copy link
Contributor Author

motiz88 commented Jul 2, 2016

Yes. For the record, this was on my Windows dev machine, running tests from path like C:\gh\project where C:\gh is a symlink to C:\Users\Moti Z\Documents\GitHub.

@bcoe bcoe merged commit e8d3785 into istanbuljs:master Jul 3, 2016
@bcoe
Copy link
Member

bcoe commented Jul 3, 2016

@motiz88 this is published in babel-plugin-istanbul@1.0.2 take it for a spin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants