-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files are erroneously ignored if process.cwd() contains symlinks #7
Comments
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Jul 1, 2016
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Jul 2, 2016
@bcoe? Anyone? |
@motiz88 mind submitting a failing unit-test, I'm not quite sure how to reproduce this failing behavior. |
I'll keep thinking about a way to put this in a unit test. Here are the repro steps:
|
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Aug 15, 2016
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Aug 26, 2016
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Sep 5, 2016
motiz88
added a commit
to motiz88/babel-plugin-istanbul
that referenced
this issue
Sep 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babel-plugin-istanbul
preprocesses paths withrealpath()
before filtering them withtest-exclude
.test-exclude
excludes paths that are outside ofprocess.cwd()
.When
process.cwd()
includes symlinks, the use ofrealpath()
means that all files will appear to be outside of the working directory.Possible solutions:
A) Resolve
process.cwd()
withrealpath()
too(PR #8 does this)
Or alternatively:
B) Don't use
realpath()
on any files at allThere may, of course, be a good reason to keep using
realpath()
that I'm not aware of.The text was updated successfully, but these errors were encountered: