Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated variable color-subtle-gray #93

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Deprecated variable color-subtle-gray #93

merged 2 commits into from
Mar 26, 2019

Conversation

pacowong99
Copy link
Contributor

To address issue #78

@levimcg levimcg requested a review from illusivesunrae March 19, 2019 16:12
illusivesunrae
illusivesunrae suggested changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@illusivesunrae illusivesunrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to the deprecation note on line 86 that the $color-subtle-gray is being deprecated in favor of $color-black--050.

@levimcg
Copy link
Member

levimcg commented Mar 25, 2019

@pacowong99 @illusivesunrae I'd like to get this finished up for the March release later this week. I'll plan to finish it up by EOD tomorrow if no one else has time to get to it first. 👍

@illusivesunrae illusivesunrae merged commit a6e9c2d into develop Mar 26, 2019
@illusivesunrae illusivesunrae deleted the feature/deprecate-subtle-gray branch March 26, 2019 14:19
@levimcg levimcg added the 1.4.0 label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illusivesunrae illusivesunrae illusivesunrae approved these changes

Assignees
No one assigned
Labels
1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacowong99 @levimcg @illusivesunrae