Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depreciate variable: $color-subtle-gray #78

Closed
basham opened this issue Feb 26, 2019 · 0 comments
Closed

Depreciate variable: $color-subtle-gray #78

basham opened this issue Feb 26, 2019 · 0 comments
Labels
good first issue A good issue for those looking to make their first contribution to Rivet

Comments

@basham
Copy link
Member

basham commented Feb 26, 2019

Since we're depreciating certain color variables in favor of using the color scale, we should depreciate $color-subtle-gray (#f7f7f7) in favor of $color-black--050 (#fafafa). They are essentially the same, and there's no need for both.

/~https://github.com/indiana-university/rivet-source/blob/v1.2.1/src/sass/core/_variables.scss#L68
@levimcg levimcg added good first issue A good issue for those looking to make their first contribution to Rivet request labels Feb 26, 2019
@pacowong99 pacowong99 mentioned this issue Mar 19, 2019
Merged
@illusivesunrae illusivesunrae removed their assignment Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good issue for those looking to make their first contribution to Rivet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@basham @levimcg @pacowong99 @illusivesunrae