Improve Error Message for throwSqlError() #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/iTwin/itwinjs-core into dan/improve-sql-err-msg-on-insert
imodeljs-admin
requested review from
calebmshafer,
wgoehrig and
a team
as code owners
|
This pull request is now in conflicts. Could you fix it @DanRod1999? 🙏 |
nick4598
reviewed
Nov 15, 2024
nick4598
reviewed
Nov 15, 2024
nick4598
approved these changes
Nov 15, 2024
aruniverse
approved these changes
Nov 15, 2024
tcobbs-bentley
approved these changes
Nov 15, 2024
|
@Mergifyio backport release/4.10.x release/4.11.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2024
Co-authored-by: Daniel Rodriguez <DanRod1999@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com> (cherry picked from commit a29c7bc) # Conflicts: # common/config/rush/pnpm-lock.yaml # core/backend/package.json # test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle # test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj # tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2024
Co-authored-by: Daniel Rodriguez <DanRod1999@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com> (cherry picked from commit a29c7bc) # Conflicts: # common/config/rush/pnpm-lock.yaml # core/backend/package.json # test-apps/display-test-app/android/imodeljs-test-app/app/build.gradle # test-apps/display-test-app/ios/imodeljs-test-app/imodeljs-test-app.xcodeproj/project.pbxproj # tools/internal/ios/core-test-runner/core-test-runner.xcodeproj/project.pbxproj
aruniverse
pushed a commit
that referenced
this pull request
Nov 21, 2024
DanRod1999
added a commit
that referenced
this pull request
Nov 21, 2024
….11.x] (#7384) Co-authored-by: Daniel Rodriguez <44824788+DanRod1999@users.noreply.github.com> Co-authored-by: Daniel Rodriguez <DanRod1999@users.noreply.github.com> Co-authored-by: imodeljs-admin <38288322+imodeljs-admin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imodel-native: iTwin/imodel-native#905
Resolves Issue
Adds test for new sql error message. See imodel-native pr for changes