Improve Error Message for throwSqlError() (backport #905) [release/4.10.x] #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](/~https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* wip use BeSQLiteLib functions * Use GetLogError * use throwSqlResult and use GetLogError * fix tab * clean up and remove comment --------- Co-authored-by: Daniel Rodriguez <DanRod1999@users.noreply.github.com> Co-authored-by: affank <khanaffan@gmail.com> Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> (cherry picked from commit f0435be)
mergify
bot
requested review from
pmconne,
khanaffan,
calebmshafer and
bbastings
as code owners
|
re running ci because this was running off of the wrong itwinjs core branch |
|
/azp run imodel-native |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DanRod1999
approved these changes
Nov 20, 2024
aruniverse
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue
itwinjs-core: iTwin/itwinjs-core#7383
Currently the throwSqlError() function only gives "SQL Error", and only after enabling sql logs can we see a more useful error message. See issue for more details.
instead of using threSqlError() I used throwSqlResult() which when given a DBResult we can gather the error message from SQL. Also expand throwSqlResult() to provide the full sql log message.
This is an automatic backport of pull request #905 done by Mergify.