List changed fixes #190
Merged
List changed fixes #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-knurek
commented
Dec 4, 2019
| @@ -705,7 +705,7 @@ func (t *Testing) ComputeChangedChartDirectories() ([]string, error) { | |||
| changedChartDirs = append(changedChartDirs, chartDir) | |||
| } | |||
| } else { | |||
| fmt.Printf("Directory '%s' is no chart directory. Skipping...", chartDir) | |||
| fmt.Printf("Directory '%s' is not a valid chart directory. Skipping...\n", dir) | |||
There was a problem hiding this comment.
When the tool found non-chart files changed, it output as:
Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...
This was extremely confusing.
jeff-knurek
commented
Dec 4, 2019
pkg/util/util.go
Outdated
| @@ -131,6 +131,7 @@ func (u ChartUtils) LookupChartDir(chartDirs []string, dir string) (string, erro | |||
| for { | |||
| chartYaml := path.Join(currentDir, "Chart.yaml") | |||
| parent := path.Dir(path.Dir(chartYaml)) | |||
| chartDir = path.Join(chartDir) // removes any trailing slash from the dir | |||
There was a problem hiding this comment.
if you try setting chart-dirs as ./, the tool gets stuck in an infinite loop. (even more confusing because . works as expected)
This was because of later in the code,
if (joined == chartDir) || strings.HasPrefix(relativeDir, "..") {
would check if . == ./.
I didn't test, but i'm pretty sure it was a similar problem with the (parent == chartDir) check as well.
added 2 commits
December 4, 2019 15:56
Signed-off-by: Jeff Knurek <j.knurek@travelaudience.com>
Signed-off-by: Jeff Knurek <j.knurek@travelaudience.com>
jeff-knurek
force-pushed
the
list-changed-fixes
branch
from
ccec0c9 to
8545bf5
Compare
Signed-off-by: Jeff Knurek <j.knurek@travelaudience.com>
unguiculus
approved these changes
Dec 8, 2019
|
Thanks 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Using
list-changedcaused a lot of confusion when trying to get the structure/config correct. This PR is to help make it more understood.