Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List changed fixes #190

Merged
merged 3 commits into from
Dec 8, 2019
Merged

List changed fixes #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4acd493
improve the messaging for better usability
Dec 4, 2019
8545bf5
remove trailing slash so that app doesn't hang in infinite looping
Dec 4, 2019
8dfb369
use different func to be more explicit of what the code is doing
Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/chart/chart.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ func (t *Testing) ComputeChangedChartDirectories() ([]string, error) {
changedChartDirs = append(changedChartDirs, chartDir)
}
} else {
fmt.Printf("Directory '%s' is no chart directory. Skipping...", chartDir)
fmt.Printf("Directory '%s' is not a valid chart directory. Skipping...\n", dir)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the tool found non-chart files changed, it output as:

Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...Directory '' is no chart directory. Skipping...

This was extremely confusing.

}
}

Expand Down
1 change: 1 addition & 0 deletions pkg/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func (u ChartUtils) LookupChartDir(chartDirs []string, dir string) (string, erro
for {
chartYaml := path.Join(currentDir, "Chart.yaml")
parent := path.Dir(path.Dir(chartYaml))
chartDir = strings.TrimRight(chartDir, "/") // remove any trailing slash from the dir

// check directory has a Chart.yaml and that it is in a
// direct subdirectory of a configured charts directory
Expand Down