Fixes failing tests for make test run in build step
#2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinay-gopalan
commented
Dec 13, 2023
| @@ -32,7 +32,7 @@ const gcpJSONCredentials string = ` | |||
| ` | |||
|
|
|||
| func TestGCPAuthBackend_basic(t *testing.T) { | |||
| testutil.SkipTestEnvSet(t, testutil.EnvVarSkipVaultNext) | |||
There was a problem hiding this comment.
This test no longer needs this skip step since all features being tested have been released. Since I was already updating the code I went ahead and removed it
vinay-gopalan
commented
Dec 13, 2023
| testutil.TestAccCheckAuthMountExists(resourceName, | ||
| &resAuth, | ||
| testProvider.Meta().(*provider.ProviderMeta).MustGetClient()), | ||
| githubAuthMountExistsHelperNS(resourceName, &resAuth), |
There was a problem hiding this comment.
This test was not getting the correct namespaced client; a wrapper method that fetches the Vault client in the correct namespace has been added to mitigate this
fairclothjm
approved these changes
Dec 13, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
testutil.SkipTestAcc(t)to a few tests that were updated as a part of #1997. The build step was previously failing since these tests were not being skipped when runningmake test(these should be skipped and only run onmake testacc). This fixes the build