Fixes failing tests for make test run in build step (#2110)

* fix duplicate features heading in changelog

* add skip test acc to acceptance tests to fix build

* add helper wrapper function for github namespace checks

CHANGELOG.md

@@ -2,13 +2,11 @@
 
 FEATURES:
 * Add support for `ext_key_usage_oids` in `vault_pki_secret_backend_role` ([#2108](/~https://github.com/hashicorp/terraform-provider-vault/pull/2108))
+* Adds support to `vault_gcp_auth_backend` for common backend tune parameters ([#1997](/~https://github.com/terraform-providers/terraform-provider-vault/pull/1997)).
 
 BUGS:
 * fix `vault_kv_secret_v2` drift when "data" is in secret name/path ([#2104](/~https://github.com/hashicorp/terraform-provider-vault/pull/2104))
 
-FEATURES:
-* Adds support to `vault_gcp_auth_backend` for common backend tune parameters ([#1997](/~https://github.com/terraform-providers/terraform-provider-vault/pull/1997)).
-
 ## 3.23.0 (Nov 15, 2023)
 
 FEATURES:

vault/resource_auth_backend_test.go

@@ -204,6 +204,8 @@ func testResourceAuth_initialCheck(expectedPath string) resource.TestCheckFunc {
 }
 
 func TestResourceAuthTune(t *testing.T) {
+	testutil.SkipTestAcc(t)
+
 	backend := acctest.RandomWithPrefix("github")
 	resName := "vault_auth_backend.test"
 	var resAuthFirst api.AuthMount

vault/resource_gcp_auth_backend_test.go

@@ -32,7 +32,7 @@ const gcpJSONCredentials string = `
 `
 
 func TestGCPAuthBackend_basic(t *testing.T) {
-	testutil.SkipTestEnvSet(t, testutil.EnvVarSkipVaultNext)
+	testutil.SkipTestAcc(t)
 
 	var resAuthFirst api.AuthMount
 	path := resource.PrefixedUniqueId("gcp-basic-")

vault/resource_github_auth_backend_test.go

@@ -10,6 +10,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
 	"github.com/hashicorp/vault/api"
 
 	"github.com/hashicorp/terraform-provider-vault/internal/consts"
@@ -90,9 +91,7 @@ func TestAccGithubAuthBackend_ns(t *testing.T) {
 			{
 				Config: testAccGithubAuthBackendConfig_ns(ns, path, testGHOrg),
 				Check: resource.ComposeTestCheckFunc(
-					testutil.TestAccCheckAuthMountExists(resourceName,
-						&resAuth,
-						testProvider.Meta().(*provider.ProviderMeta).MustGetClient()),
+					githubAuthMountExistsHelperNS(resourceName, &resAuth),
 					resource.TestCheckResourceAttr(resourceName, "id", path),
 					resource.TestCheckResourceAttr(resourceName, consts.FieldPath, path),
 					resource.TestCheckResourceAttr(resourceName, "organization", testGHOrg),
@@ -107,6 +106,26 @@ func TestAccGithubAuthBackend_ns(t *testing.T) {
 	})
 }
 
+func githubAuthMountExistsHelperNS(resourceName string, out *api.AuthMount) resource.TestCheckFunc {
+	return func(s *terraform.State) error {
+		rs, ok := s.RootModule().Resources[resourceName]
+		if !ok {
+			return fmt.Errorf("Not found: %s", resourceName)
+		}
+
+		if rs.Primary.ID == "" {
+			return fmt.Errorf("No id for %s is set", resourceName)
+		}
+
+		client, e := provider.GetClient(rs.Primary, testProvider.Meta())
+		if e != nil {
+			return e
+		}
+
+		return testutil.AuthMountExistsHelper(resourceName, s, out, client)
+	}
+}
+
 func TestAccGithubAuthBackend_tuning(t *testing.T) {
 	testutil.SkipTestAcc(t)
 
@@ -224,6 +243,8 @@ func TestAccGithubAuthBackend_description(t *testing.T) {
 }
 
 func TestAccGithubAuthBackend_importTuning(t *testing.T) {
+	testutil.SkipTestAcc(t)
+
 	path := acctest.RandomWithPrefix("github")
 	resourceType := "vault_github_auth_backend"
 	resourceName := resourceType + ".test"
@@ -245,6 +266,8 @@ func TestAccGithubAuthBackend_importTuning(t *testing.T) {
 }
 
 func TestGithubAuthBackend_remount(t *testing.T) {
+	testutil.SkipTestAcc(t)
+
 	path := acctest.RandomWithPrefix("tf-test-gh")
 	updatedPath := acctest.RandomWithPrefix("tf-test-gh-updated")