Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout in monitor (0.119) #9871

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

steven-sheehy
Copy link
Member

Description:

Cherry pick #9870 to release/0.119

  • Add a hedera.mirror.monitor.nodes.certHash property
  • Fix TLS connectivity by setting client.setNetworkFromAddressBook() using address book created from /api/v1/network/nodes

Related issue(s):

Fixes #9869

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Add a `hedera.mirror.monitor.nodes.certHash` property
* Fix TLS connectivity by setting `client.setNetworkFromAddressBook()` using address book created from `/api/v1/network/nodes`

---------

Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working monitor Area: Monitoring and dashboard labels Dec 4, 2024
@steven-sheehy steven-sheehy added this to the 0.119.0 milestone Dec 4, 2024
@steven-sheehy steven-sheehy self-assigned this Dec 4, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner December 4, 2024 22:42
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 80.48780% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.25%. Comparing base (71e23ee) to head (24d7ffe).
Report is 2 commits behind head on release/0.119.

Files with missing lines Patch % Lines
...java/com/hedera/mirror/monitor/NodeProperties.java 62.50% 3 Missing and 3 partials ⚠️
...om/hedera/mirror/monitor/publish/NodeSupplier.java 90.90% 1 Missing ⚠️
...a/mirror/monitor/publish/TransactionPublisher.java 92.85% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/0.119    #9871      +/-   ##
===================================================
- Coverage            92.27%   92.25%   -0.03%     
- Complexity            7771     7772       +1     
===================================================
  Files                  951      951              
  Lines                32468    32498      +30     
  Branches              4116     4118       +2     
===================================================
+ Hits                 29959    29980      +21     
- Misses                1545     1550       +5     
- Partials               964      968       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 4, 2024

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 653bafe into release/0.119 Dec 5, 2024
30 of 31 checks passed
@steven-sheehy steven-sheehy deleted the 9869-monitor-tls-119 branch December 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working monitor Area: Monitoring and dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants