Fix timeout in monitor #9870
Merged
Fix timeout in monitor #9870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
steven-sheehy
added
bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9870 +/- ##
============================================
- Coverage 92.27% 92.25% -0.02%
- Complexity 7771 7772 +1
============================================
Files 951 951
Lines 32472 32502 +30
Branches 4118 4120 +2
============================================
+ Hits 29962 29984 +22
- Misses 1546 1551 +5
- Partials 964 967 +3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
|
steven-sheehy
added a commit
that referenced
this pull request
Dec 4, 2024
* Add a `hedera.mirror.monitor.nodes.certHash` property * Fix TLS connectivity by setting `client.setNetworkFromAddressBook()` using address book created from `/api/v1/network/nodes` --------- Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
2 tasks
steven-sheehy
added a commit
that referenced
this pull request
Dec 5, 2024
Fix timeout in monitor (#9870) * Add a `hedera.mirror.monitor.nodes.certHash` property * Fix TLS connectivity by setting `client.setNetworkFromAddressBook()` using address book created from `/api/v1/network/nodes` --------- Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
hedera.mirror.monitor.nodes.certHashpropertyclient.setNetworkFromAddressBook()using address book created from/api/v1/network/nodesRelated issue(s):
Fixes #9869
Notes for reviewer:
Checklist