HIP 904 add token associate on claim airdrop #9841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9841 +/- ##
============================================
- Coverage 92.27% 92.25% -0.02%
- Complexity 7771 7778 +7
============================================
Files 951 951
Lines 32472 32526 +54
Branches 4118 4123 +5
============================================
+ Hits 29962 30008 +46
- Misses 1546 1550 +4
- Partials 964 968 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
…ciate Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
xin-hedera
requested changes
Dec 3, 2024
...ter/src/main/java/com/hedera/mirror/importer/parser/record/entity/sql/SqlEntityListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
|
steven-sheehy
added a commit
that referenced
this pull request
Dec 4, 2024
* Associates a token when a claim airdrop occurs * Change balance generation transaction timeout from 5m to 10m * Handle scenario where user manually associates token before claiming --------- Signed-off-by: Edwin Greene <edwin@swirldslabs.com> Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> Co-authored-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
2 tasks
steven-sheehy
added a commit
that referenced
this pull request
Dec 4, 2024
HIP 904 add token associate on claim airdrop (#9841) * Associates a token when a claim airdrop occurs * Change balance generation transaction timeout from 5m to 10m * Handle scenario where user manually associates token before claiming --------- Signed-off-by: Edwin Greene <edwin@swirldslabs.com> Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> Co-authored-by: Edwin Greene <edwin@hashgraph.com>
steven-sheehy
added a commit
that referenced
this pull request
Dec 5, 2024
* Associates a token when a claim airdrop occurs * Change balance generation transaction timeout from 5m to 10m * Handle scenario where user manually associates token before claiming --------- Signed-off-by: Edwin Greene <edwin@swirldslabs.com> Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> Co-authored-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
2 tasks
steven-sheehy
added a commit
that referenced
this pull request
Dec 5, 2024
HIP 904 add token associate on claim airdrop (#9841) * Associates a token when a claim airdrop occurs * Change balance generation transaction timeout from 5m to 10m * Handle scenario where user manually associates token before claiming --------- Signed-off-by: Edwin Greene <edwin@swirldslabs.com> Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com> Co-authored-by: Edwin Greene <edwin@hashgraph.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #9865
Notes for reviewer:
Tested with claim airdrop transaction on Testnet. With this change, the token airdrop correctly appears in the
token_accounttable after the claim.Checklist