Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP 904 add token associate on claim airdrop (0.118) #9876

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

steven-sheehy
Copy link
Member

Description:

Cherry pick #9841 to release/0.118

  • Associates a token when a claim airdrop occurs
  • Change balance generation transaction timeout from 5m to 10m
  • Handle scenario where user manually associates token before claiming

Related issue(s):

Fixes #9865

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Associates a token when a claim airdrop occurs
* Change balance generation transaction timeout from 5m to 10m
* Handle scenario where user manually associates token before claiming

---------

Signed-off-by: Edwin Greene <edwin@swirldslabs.com>
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
Co-authored-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working hts Hedera Token Service importer Area: Importer labels Dec 5, 2024
@steven-sheehy steven-sheehy self-assigned this Dec 5, 2024
@steven-sheehy steven-sheehy requested a review from a team as a code owner December 5, 2024 16:33
@steven-sheehy steven-sheehy added this to the 0.118.1 milestone Dec 5, 2024
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.24%. Comparing base (8bf5324) to head (04eee73).
Report is 1 commits behind head on release/0.118.

Files with missing lines Patch % Lines
.../AbstractTokenUpdateAirdropTransactionHandler.java 94.11% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.118    #9876   +/-   ##
================================================
  Coverage            92.23%   92.24%           
- Complexity            7628     7634    +6     
================================================
  Files                  937      937           
  Lines                32121    32145   +24     
  Branches              4072     4075    +3     
================================================
+ Hits                 29626    29651   +25     
+ Misses                1542     1541    -1     
  Partials               953      953           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 5, 2024

Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@steven-sheehy steven-sheehy merged commit 1f9cb50 into release/0.118 Dec 5, 2024
31 checks passed
@steven-sheehy steven-sheehy deleted the hip904-add-token-associate-118 branch December 5, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working hts Hedera Token Service importer Area: Importer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants