-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiValues component names export #1038
MultiValues component names export #1038
Conversation
Implementation for parallel vtk missing
Moved components naming into MultiValue's API and set a default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
+ Coverage 88.40% 88.42% +0.01%
==========================================
Files 180 180
Lines 23239 23273 +34
==========================================
+ Hits 20545 20578 +33
- Misses 2694 2695 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a very minor comment.
Otherwise, everything looks great. Remember to pull from master and update NEWS.md
with a small description of what you've done. After you are done I'll accept the PR.
src/Visualization/Vtk.jl
Outdated
@@ -94,10 +94,12 @@ function create_vtk_file( | |||
|
|||
if num_cells(trian)>0 | |||
for (k,v) in celldata | |||
vtk_cell_data(vtkfile, _prepare_data(v), k) | |||
comp_names = _data_component_names(v) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace this by
component_names = _data_component_names(v)
vtk_cell_data(vtkfile, _prepare_data(v), k; component_names)
and idem everywhere else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didn't know this trick, I changed these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the setindex overload is so cursed that I cannot avoid repeating the kwarg name in it :') .
Fixes #1036.