Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiValues component names export #1038

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

Antoinemarteau
Copy link
Contributor

Fixes #1036.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (309221b) to head (78e7db6).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/TensorValues/SymFourthOrderTensorValueTypes.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   88.40%   88.42%   +0.01%     
==========================================
  Files         180      180              
  Lines       23239    23273      +34     
==========================================
+ Hits        20545    20578      +33     
- Misses       2694     2695       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JordiManyer JordiManyer self-requested a review October 21, 2024 04:46
Copy link
Member

@JordiManyer JordiManyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a very minor comment.
Otherwise, everything looks great. Remember to pull from master and update NEWS.md with a small description of what you've done. After you are done I'll accept the PR.

@@ -94,10 +94,12 @@ function create_vtk_file(

if num_cells(trian)>0
for (k,v) in celldata
vtk_cell_data(vtkfile, _prepare_data(v), k)
comp_names = _data_component_names(v)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace this by

component_names = _data_component_names(v)
vtk_cell_data(vtkfile, _prepare_data(v), k; component_names)

and idem everywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know this trick, I changed these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the setindex overload is so cursed that I cannot avoid repeating the kwarg name in it :') .

@JordiManyer JordiManyer merged commit 682999c into gridap:master Oct 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiValues components naming in vtk exports
2 participants