Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

app:service: convert to dep injection #5

Merged
merged 3 commits into from
Dec 16, 2020
Merged

Conversation

compscidr
Copy link
Collaborator

Previously the code was untestable in certain places because the SessionManager used a enum / static singleton pattern. This has been fixed and some tests have been implemented for the new method.

Addresses: #4

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #5 (6254a48) into main (1587f3d) will increase coverage by 8.66%.
The diff coverage is 45.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main       #5      +/-   ##
============================================
+ Coverage     34.98%   43.64%   +8.66%     
- Complexity       84      100      +16     
============================================
  Files            23       23              
  Lines           826      811      -15     
  Branches         85       84       -1     
============================================
+ Hits            289      354      +65     
+ Misses          533      454      -79     
+ Partials          4        3       -1     
Impacted Files Coverage Δ Complexity Δ
...in/java/network/grape/service/GrapeVpnService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/network/grape/service/SessionHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ain/java/network/grape/service/SessionManager.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/network/grape/service/SocketProtector.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../network/grape/service/SocketDataReaderWorker.java 7.79% <60.00%> (+1.21%) 1.00 <1.00> (ø)
.../network/grape/service/SocketDataWriterWorker.java 9.52% <60.00%> (+1.45%) 1.00 <1.00> (ø)
...src/main/java/network/grape/service/VpnWriter.java 100.00% <100.00%> (+75.58%) 28.00 <4.00> (+16.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1587f3d...6254a48. Read the comment docs.

@compscidr compscidr merged commit 9fa758a into main Dec 16, 2020
@compscidr compscidr deleted the feature/dep-injection branch December 19, 2020 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant