Refactor NetworkManager.onLoadingFinished #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
refactor/nm-onLoadingFinished
branch
from
1a939f5 to
01f0eef
Compare
3 tasks
This is a prior to fixing the bug #1072.
inancgumus
force-pushed
the
refactor/nm-onLoadingFinished
branch
from
01f0eef to
93ca042
Compare
ankur22
approved these changes
Oct 26, 2023
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
ka3de
approved these changes
Oct 26, 2023
| @@ -347,37 +347,52 @@ func (m *NetworkManager) onLoadingFailed(event *network.EventLoadingFailed) { | |||
| } | |||
|
|
|||
| func (m *NetworkManager) onLoadingFinished(event *network.EventLoadingFinished) { | |||
| req := m.requestFromID(event.RequestID) | |||
| rid := event.RequestID | |||
There was a problem hiding this comment.
Sorry, too long :) It feels more idiomatic to use rid. Thanks for the suggestion, though.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactors
NetworkManager.onLoadingFinishedto fix linter warnings.Why?
This is before fixing bug #1072. Otherwise, We'd have to do the refactoring in #1078.
Checklist
Related PR(s)/Issue(s)
Related: #1078