Merge network interception deadlock bug fix #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please see the comment inside code to understand why this fix is needed.
This is a prior to fixing the bug #1072.
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
Co-authored-by: ka3de <daniel.jimenez@grafana.com>
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Rebases #1072 fixes for
main. These were reviewed earlier in #1084 and #1078. The only difference is this commit that makes some cosmetic changes: 8f9a385.Why?
We should fix the deadlock behavior #1072 also on
main.Checklist
Related PR(s)/Issue(s)
Updated: #1072