feat: Automated backups are supported in the admin client #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
cindy-peng
approved these changes
Feb 5, 2025
| this.instanceId = tableName.getInstance(); | ||
| this.id = tableName.getTable(); | ||
| this.replicationStatesByClusterId = replicationStatesByClusterId; | ||
| this.columnFamilies = columnFamilies; | ||
| this.changeStreamRetention = changeStreamRetention; | ||
| this.deletionProtection = deletionProtection; | ||
| Table.automatedBackupPolicy = automatedBackupPolicy; |
There was a problem hiding this comment.
Should this be: this.automatedBackupPolicy = automatedBackupPolicy;?
There was a problem hiding this comment.
So because it's a static field, I need to set it in a static way.
Here's the error I get if I try to replace Table with this:
The static field Table.automatedBackupPolicy should be accessed in a static wayJava(570425420)
| @@ -136,13 +145,15 @@ public void testEquality() { | |||
| CreateTableRequest.of(TABLE_ID) | |||
| .addFamily("family-id") | |||
| .addFamily("another-family", GCRULES.maxAge(100, TimeUnit.HOURS)) | |||
| // automatedbackup | |||
There was a problem hiding this comment.
Oops sorry forgot to push commit, thanks for catching.
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
…#2472) * add automated backup policy model * add automated backup policy for create table * add updated automated backup requests * add backup policy object to table class and retrieval methods * changes to table.java * revert doc change * add unit test for policy setting on a table * add new test for creating automated backup * remove misc vscode settings file * undo formatting changes in authorized views * revert formatting * continue revert * redo formatting * remove authorized views formatting * add unit tests * fix syntax on unit test * fix unit test * fix formatting
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
…#2472) * add automated backup policy model * add automated backup policy for create table * add updated automated backup requests * add backup policy object to table class and retrieval methods * changes to table.java * revert doc change * add unit test for policy setting on a table * add new test for creating automated backup * remove misc vscode settings file * undo formatting changes in authorized views * revert formatting * continue revert * redo formatting * remove authorized views formatting * add unit tests * fix syntax on unit test * fix unit test * fix formatting
sarthakbhutani
pushed a commit
to sarthakbhutani/java-bigtable
that referenced
this pull request
Feb 13, 2025
…#2472) * add automated backup policy model * add automated backup policy for create table * add updated automated backup requests * add backup policy object to table class and retrieval methods * changes to table.java * revert doc change * add unit test for policy setting on a table * add new test for creating automated backup * remove misc vscode settings file * undo formatting changes in authorized views * revert formatting * continue revert * redo formatting * remove authorized views formatting * add unit tests * fix syntax on unit test * fix unit test * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports automated backups for the Java Bigtable client.
AutomatedBackupPolicysubclass to theTableclass.CreateTableRequestclass.UpdateTableRequestclass.