-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automated backups are supported in the admin client #2472
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
68c7265
add automated backup policy model
kevkim-codes d25f28f
add automated backup policy for create table
kevkim-codes c80b434
add updated automated backup requests
kevkim-codes af2c5cf
add backup policy object to table class and retrieval methods
kevkim-codes 61cea45
changes to table.java
kevkim-codes fd8c350
revert doc change
kevkim-codes c4fcd5d
add unit test for policy setting on a table
kevkim-codes 12899b3
add new test for creating automated backup
kevkim-codes b3b53f8
remove misc vscode settings file
kevkim-codes 6551b8f
undo formatting changes in authorized views
kevkim-codes a3c0d03
revert formatting
kevkim-codes 8d85274
continue revert
kevkim-codes 0d994ee
redo formatting
kevkim-codes 9f09582
remove authorized views formatting
kevkim-codes 23d9a22
add unit tests
kevkim-codes 65148bc
Merge branch 'main' into backup
kevkim-codes 9d034b4
fix syntax on unit test
kevkim-codes bdd502b
fix unit test
kevkim-codes b47b943
fix formatting
kevkim-codes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
this.automatedBackupPolicy = automatedBackupPolicy;
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So because it's a static field, I need to set it in a
static
way.Here's the error I get if I try to replace
Table
withthis
:The static field Table.automatedBackupPolicy should be accessed in a static wayJava(570425420)