doc: CHANGELOG entry for #8022 #12507
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #12507 +/- ##
==========================================
- Coverage 93.63% 93.62% -0.01%
==========================================
Files 2043 2043
Lines 180935 180935
==========================================
- Hits 169410 169408 -2
- Misses 11525 11527 +2 ☔ View full report in Codecov by Sentry. |
CHANGELOG.md
Outdated
| @@ -140,6 +140,48 @@ The library has been expanded to include the v2 service. | |||
| consider this a breaking change, as Bazel 5.x has been in maintenance mode for | |||
| more than 6 months. | |||
|
|
|||
| **CMake Proto Libraries**: We no longer compile certain protos, unless the | |||
There was a problem hiding this comment.
Maybe "we only compile the service-specific protos if the corresponding client library is enabled via `-DGOOGLE_CLOUD_CPP_ENABLE" ?
CHANGELOG.md
Outdated
| **CMake Proto Libraries**: We no longer compile certain protos, unless the | ||
| corresponding client library is enabled, via `-DGOOGLE_CLOUD_CPP_ENABLE=...`. | ||
|
|
||
| This change reduces build times with `cmake` for customers who build with |
There was a problem hiding this comment.
I would use CMake (without code style) in this context. I think we should use cmake (with code style) when referring to the command itself, not the system.
There was a problem hiding this comment.
And remove the "with CMake" duplication. So, "This change reduces build times for customers who use CMake but who are not using ...."
CHANGELOG.md
Outdated
| this change eclipse the number of customers who are affected negatively by it. | ||
| Hence, we think this change is necessary. | ||
|
|
||
| We offered many of these proto libraries before we could write and maintain the |
There was a problem hiding this comment.
This information probably belongs in the comments on #8022, but maybe not here.
CHANGELOG.md
Outdated
| Note that `google_cloud_cpp_storage_protos` are associated with the | ||
| `experimental-storage-grpc` feature, not the `storage` feature. | ||
|
|
||
| We do not make changes that can break our customers lightly. We considered it |
There was a problem hiding this comment.
Maybe move the paragraph earlier, maybe before "The impacted libraries". And maybe consider something like:
Compiling these protos when not strictly needed was a bug for some customers, and confusing to other customers.
Any change in behavior, including fixing bugs, can be considered "breaking". By policy we don't consider bug fixes to be breaking changes. And we applied that policy in this case.
Skip the comment about the number of customers affected.
There was a problem hiding this comment.
Maybe move the paragraph earlier, maybe before "The impacted libraries".
Done.
maybe consider something like:
I used your second paragraph, but I preferred my first paragraph.
Skip the comment about the number of customers affected.
Done.
CHANGELOG.md
Outdated
| compiling the corresponding client library, you will need to update your build | ||
| scripts. | ||
|
|
||
| For example, if you depend on `google_cloud_cpp_speech_protos`, (e.g. if you |
There was a problem hiding this comment.
took two commits, but done.
This change is