Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: CHANGELOG entry for #8022 #12507

Merged
merged 5 commits into from
Sep 1, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,45 @@ The library has been expanded to include the v2 service.
consider this a breaking change, as Bazel 5.x has been in maintenance mode for
more than 6 months.

**CMake Proto Libraries**: We only compile service-specific protos if the
corresponding client library is enabled, via `-DGOOGLE_CLOUD_CPP_ENABLE=...`.

This change reduces build times for customers who use CMake but who are not
using **all** of the client libraries listed below.

We considered it [a bug][#8022] that customers building with CMake were forced
to compile large proto libraries that they did not need. It was certainly
[confusing][#10174].

Any change in behavior, including fixing bugs, can be considered "breaking". By
policy we don't consider bug fixes to be breaking changes. We applied that
policy in this case.

The impacted libraries are:

- `bigquery`
- `bigtable`
- `dialogflow_es`
- `iam`
- `logging`
- `pubsub`
- `speech`
- `storage`
- `texttospeech`
- `trace`

If you are dependent on any of these proto libraries **and** you are not
compiling the corresponding client library, you will need to update your build
scripts.

For example, if you depend on `google_cloud_cpp_speech_protos`, (e.g. if you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/, (e.g. if/ (e.g., if/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took two commits, but done.

have been using this library to make calls to Cloud Speech using raw gRPC), add
`-DGOOGLE_CLOUD_CPP_ENABLE=...,speech,...` to your CMake configure command. If
you build with `vcpkg`, include `speech` in your install command.

Note that `google_cloud_cpp_storage_protos` are associated with the
`experimental-storage-grpc` feature, not the `storage` feature.

## v2.14.0 - 2023-08

### New Libraries
Expand Down Expand Up @@ -4247,13 +4286,15 @@ releases. The relevant notes are:
- Synchronous API for table admin operations is complete.

[#10170]: /~https://github.com/googleapis/google-cloud-cpp/issues/10170
[#10174]: /~https://github.com/googleapis/google-cloud-cpp/discussions/10174
[#5726]: /~https://github.com/googleapis/google-cloud-cpp/issues/5726
[#5923]: /~https://github.com/googleapis/google-cloud-cpp/issues/5923
[#5929]: /~https://github.com/googleapis/google-cloud-cpp/issues/5929
[#5976]: /~https://github.com/googleapis/google-cloud-cpp/issues/5976
[#7356]: /~https://github.com/googleapis/google-cloud-cpp/issues/7356
[#7463]: /~https://github.com/googleapis/google-cloud-cpp/issues/7463
[#7835]: /~https://github.com/googleapis/google-cloud-cpp/issues/7835
[#8022]: /~https://github.com/googleapis/google-cloud-cpp/issues/8022
[#8095]: /~https://github.com/googleapis/google-cloud-cpp/pull/8095
[#8099]: /~https://github.com/googleapis/google-cloud-cpp/pull/8099
[#8234]: /~https://github.com/googleapis/google-cloud-cpp/issues/8234
Expand Down