Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(genrest): fix casing for body field #1293

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

noahdietz
Copy link
Collaborator

Request body fields that are snake_case were not being CamelCase'd properly as strings.Title does not convert snake_case to CamelCase, it just sets the first letter in each word to uppercase, but without splitting on _ first.

Tested with changes in #1266 .

Blocking #1266

@noahdietz noahdietz requested a review from a team as a code owner April 10, 2023 22:41
@noahdietz noahdietz added the automerge Summon MOG for automerging label Apr 10, 2023
@noahdietz noahdietz merged commit 735d686 into googleapis:main Apr 10, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants