feat: add proto + logic for streaming sequence

[leahecole]

Hi Noah! Per our conversation on Friday, @galz10 and I are proposing these changes to the proto - we think it should be the same as AttemptSequence in the proto but the underlying logic will be different, and that the other methods are reusable. Let us know if we're off base!

[leahecole]

Moving back to draft status while things are failing - guessing it's because we're modifying the proto and not the logic, but that's just a guess

[leahecole]

(sorry for all of the force pushes - not my norm. I was rebasing to try to get co-authors working and there was a bit of trial and error with syntax - finally figured it out!)

[noahdietz]

@noahdietz Do you know what part of the sequence.proto generates GetStreamsequence ?

I think the RPC name is GetStreamingSequenceReport with the ing in Streaming. Different from what you wrote above. Is that the issue?

[galz10]

i accidentally miss typed in the comment , if you look at the failing tests its not missing the ing in streaming

@noahdietz Do you know what part of the sequence.proto generates GetStreamsequence ?

I think the RPC name is GetStreamingSequenceReport with the ing in Streaming. Different from what you wrote above. Is that the issue?

[noahdietz]

Oh, ok I just suggested a fix. The getters on a generated message e.g. CreateStreamingSequence will take the snake_case field name and name the function Get{CamelCaseOfFieldName}. That's why we use snake_case in protos for field names.

[galz10]

Oh, ok I just suggested a fix. The getters on a generated message e.g. CreateStreamingSequence will take the snake_case field name and name the function Get{CamelCaseOfFieldName}. That's why we use snake_case in protos for field names.

still failing

[noahdietz]

Oh, ok I just suggested a fix. The getters on a generated message e.g. CreateStreamingSequence will take the snake_case field name and name the function Get{CamelCaseOfFieldName}. That's why we use snake_case in protos for field names.

still failing

Was everything regenerated? Any time a proto is changed, the code needs to be regenerated and the handlers need to be updated

[galz10]

Oh, ok I just suggested a fix. The getters on a generated message e.g. CreateStreamingSequence will take the snake_case field name and name the function Get{CamelCaseOfFieldName}. That's why we use snake_case in protos for field names.

still failing

Was everything regenerated? Any time a proto is changed, the code needs to be regenerated and the handlers need to be updated

yes it was regenerated, even if i change the GetStreamingsequence to GetStreamingSequence and regenerate it generates GetStreamingsequence

[galz10]

@noahdietz So it looks like line 53 in sequence.proto needs to be streaming_sequence to generate GetStreamingSequence correctly

[noahdietz]

Update your branch as #1293 has been merged. Then reinstall genrest and regenerate locally.

[noahdietz]

Implementation is looking great, just the one question on the proto

[noahdietz]

Great job the both of you.