chore: gofmt fixes #1290
Merged
chore: gofmt fixes #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, this is super helpful! |
galz10
added a commit
that referenced
this pull request
Apr 12, 2023
* feat: add proto descriptions for streaming sequence Co-authored-by: Leah Cole <coleleah@google.com> Co-authored-by: Gal Zahavi <galzahavi@google.com> * fix: fix test failure - change endpoint for AttemptStreamingSequence Co-authored-by: Leah Cole <coleleah@google.com> Co-authored-by: Gal Zahavi <galzahavi@google.com> * fix: update URI per Noah's suggestion Co-authored-by: Leah Cole <coleleah@google.com> Co-authored-by: Gal Zahavi <galzahavi@google.com> * fix: adjust indentation Co-authored-by: Leah Cole <coleleah@google.com> Co-authored-by: Gal Zahavi <galzahavi@google.com> * update return type * Added StreamingSequence Service Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com> * Created StreamingSequence file and added functions Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com> * changed AttemptStreamingSequence function Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com> * updated AttemptStreamingSequence * updated StreamSequence to support stream resuming * fixed StreamReport not being found issue * cleanup: small style changes * condense streaming logic into sequence svc files * added StreamingSequence tests * lint fixes * chore: gofmt fixes (#1290) * Apply suggestions from code review style fixes related to snake/camel case Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com> * address comments * Update schema/google/showcase/v1beta1/sequence.proto Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com> * changed streaming_sequence to streamingSequence * fixed failing GetStreamingsequence issue * change Streaming_squence to streaming_sequence * regenerated sequence service * fixed lint failure * changed method_signature to StreamingSequence * revert changes * regenerated genrest * edit AttemptStreamingSeq.error to attempt_status * changed AttemptStreamingSequenceRequest comment * remove status from AttemptStreamingSequenceRequest --------- Co-authored-by: Gal Zahavi <galzahavi@google.com> Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com> Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com> Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the difference between our environments was, perhaps the Go version used (gofmt can change between versions). Anyways here are the fixes @leahecole @galz10
gofmt -w ./server/servicesOn my workstation, using Go:
go version go1.21-20230317-RC01 cl/517508637 +f53a95fe39 linux/amd64On my laptop, using Go:
go version go1.20.3 darwin/amd64