Skip to content

Commit

Permalink
feat: add proto + logic for streaming sequence (#1266)
Browse files Browse the repository at this point in the history
* feat: add proto descriptions for streaming sequence

Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: Gal Zahavi <galzahavi@google.com>

* fix: fix test failure - change endpoint for AttemptStreamingSequence

Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: Gal Zahavi <galzahavi@google.com>

* fix: update URI per Noah's suggestion

Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: Gal Zahavi <galzahavi@google.com>

* fix: adjust indentation

Co-authored-by: Leah Cole <coleleah@google.com>
Co-authored-by: Gal Zahavi <galzahavi@google.com>

* update return type

* Added StreamingSequence Service

Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com>

* Created StreamingSequence file and added functions

Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com>

* changed AttemptStreamingSequence function

Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com>

* updated AttemptStreamingSequence

* updated StreamSequence to support stream resuming

* fixed StreamReport not being found issue

* cleanup: small style changes

* condense streaming logic into sequence svc files

* added StreamingSequence tests

* lint fixes

* chore: gofmt fixes (#1290)

* Apply suggestions from code review

style fixes related to snake/camel case

Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>

* address comments

* Update schema/google/showcase/v1beta1/sequence.proto

Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>

* changed streaming_sequence to streamingSequence

* fixed failing GetStreamingsequence issue

* change Streaming_squence to streaming_sequence

* regenerated sequence service

* fixed lint failure

* changed method_signature to StreamingSequence

* revert changes

* regenerated genrest

* edit AttemptStreamingSeq.error to attempt_status

* changed AttemptStreamingSequenceRequest comment

* remove status from AttemptStreamingSequenceRequest

---------

Co-authored-by: Gal Zahavi <galzahavi@google.com>
Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>
Co-authored-by: Leah E. Cole <leahecole@users.noreply.github.com>
Co-authored-by: Noah Dietz <noahdietz@users.noreply.github.com>
  • Loading branch information
5 people authored Apr 12, 2023
1 parent b2cb293 commit 82814d8
Show file tree
Hide file tree
Showing 21 changed files with 2,627 additions and 396 deletions.
30 changes: 30 additions & 0 deletions client/gapic_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,11 @@
"AttemptSequence"
]
},
"AttemptStreamingSequence": {
"methods": [
"AttemptStreamingSequence"
]
},
"CancelOperation": {
"methods": [
"CancelOperation"
Expand All @@ -821,6 +826,11 @@
"CreateSequence"
]
},
"CreateStreamingSequence": {
"methods": [
"CreateStreamingSequence"
]
},
"DeleteOperation": {
"methods": [
"DeleteOperation"
Expand All @@ -846,6 +856,11 @@
"GetSequenceReport"
]
},
"GetStreamingSequenceReport": {
"methods": [
"GetStreamingSequenceReport"
]
},
"ListLocations": {
"methods": [
"ListLocations"
Expand Down Expand Up @@ -876,6 +891,11 @@
"AttemptSequence"
]
},
"AttemptStreamingSequence": {
"methods": [
"AttemptStreamingSequence"
]
},
"CancelOperation": {
"methods": [
"CancelOperation"
Expand All @@ -886,6 +906,11 @@
"CreateSequence"
]
},
"CreateStreamingSequence": {
"methods": [
"CreateStreamingSequence"
]
},
"DeleteOperation": {
"methods": [
"DeleteOperation"
Expand All @@ -911,6 +936,11 @@
"GetSequenceReport"
]
},
"GetStreamingSequenceReport": {
"methods": [
"GetStreamingSequenceReport"
]
},
"ListLocations": {
"methods": [
"ListLocations"
Expand Down
Loading

0 comments on commit 82814d8

Please sign in to comment.