-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Port Code Examples to C# (F, G, H, I, J, K, L) #43239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
requested changes
Nov 1, 2020
applied code review |
aaronfranke
requested changes
Nov 1, 2020
HaSa1002
force-pushed
the
docs-lang-4
branch
3 times, most recently
from
November 1, 2020 09:15
42181c4
to
d9da1d3
Compare
Needs a rebase. |
HaSa1002
force-pushed
the
docs-lang-4
branch
from
November 16, 2020 21:46
d9da1d3
to
c45f329
Compare
done |
HaSa1002
force-pushed
the
docs-lang-4
branch
from
November 16, 2020 21:52
c45f329
to
63d4ac8
Compare
aaronfranke
requested changes
Nov 16, 2020
HaSa1002
force-pushed
the
docs-lang-4
branch
from
November 17, 2020 17:27
5408e0a
to
87111cf
Compare
@HaSa1002 This looks pretty good, but it needs a rebase. If you rebase this, I will give it a ✔️ |
Includes: * File * Geometry2D * HashingContext * HTTPClient * HTTPRequest * Image * Input * int * ItemList * JSONParseResult * KinematicBody2D * LineEdit Co-authored-by: Aaron Franke <arnfranke@yahoo.com>
HaSa1002
force-pushed
the
docs-lang-4
branch
from
November 25, 2020 21:15
87111cf
to
5a01c2a
Compare
rebased |
aaronfranke
approved these changes
Nov 25, 2020
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
There are a few things I noticed:
Image.set_pixel(v)
methods used variables that were never declared in order to provide minimum compilable examplesto_json
andparse_json
methods like we have in GDScript. I used JSON.Print and JSON.ParseI stopped adding more classes to this PR, because I have to fix the MainLoop example first which requires changes to the logic and better deserves its own PR.
I compiled all examples in 3.2.3 Mono except for those that require 4.0.