Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a variable being redeclared in the HTTPRequest code sample #43241

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Fix a variable being redeclared in the HTTPRequest code sample #43241

merged 1 commit into from
Nov 1, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 31, 2020

Thanks @HaSa1002 for making me spot this 🙂

@Calinou Calinou requested a review from a team as a code owner October 31, 2020 18:21
@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation labels Oct 31, 2020
@Calinou Calinou added this to the 4.0 milestone Oct 31, 2020
@HaSa1002
Copy link
Contributor

HaSa1002 commented Oct 31, 2020 •
edited
Loading

oh well. I fixed it in #43239 too :D But your change is likely being merged faster :D

@akien-mga akien-mga merged commit 7bc74b0 into godotengine:master Nov 1, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 11, 2020
@Calinou Calinou deleted the doc-httprequest-fix-code-sample branch March 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @HaSa1002 @akien-mga