Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1010: Fix Testnet Chainspec: make initial set invulnerable #170

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

pLabarta
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov
Copy link
Contributor

Note to self: we can pull-in /~https://github.com/gluwa/creditcoin/blob/dev/integration-tests/src/test/danger-will-brick-the-blockchain.test.ts as part of this PR and/or do a bit more sanity checking. Will take another look into it once done with CSUB-978

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests & passing results in #171 (comment)

@pLabarta pLabarta marked this pull request as ready for review January 16, 2024 17:00
Copy link
Contributor

@zacharyfrederick zacharyfrederick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see we are using the invulnerables setting. We should probably document it somewhere for the community. I would like to know that info.

@atodorov atodorov merged commit 6ee6322 into dev Jan 18, 2024
25 of 26 checks passed
@atodorov atodorov deleted the fix-testnet-spec branch January 18, 2024 17:07
@atodorov atodorov changed the title Fix Testnet Chainspec: make initial set invulnerable CSUB-1010: Fix Testnet Chainspec: make initial set invulnerable Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants