Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-1010: Add integration tests for blockchain & check block time from chainspec #171

Merged
merged 7 commits into from
Jan 18, 2024
Merged

CSUB-1010: Add integration tests for blockchain & check block time from chainspec #171

merged 7 commits into from
Jan 18, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

@atodorov atodorov force-pushed the testing/add-integration-tests-for-blockchain branch 4 times, most recently from de0cc42 to 6c23889 Compare January 16, 2024 15:13
@atodorov
Copy link
Contributor Author

Example of the 2 build-creditcoin-node jobs running independently:
/~https://github.com/gluwa/creditcoin3/actions/runs/7543269625?pr=171

Example of the -fast-runtime build reusing cache from the previous build (much faster):
/~https://github.com/gluwa/creditcoin3/actions/runs/7543635701?pr=171

@atodorov
Revert "removed blockchain integration tests"
fa7e2aa 
This reverts commit 98c81cb b/c we want
to start executing integration tests against the blockchain again.
@atodorov
Add integration test for block time
d5e9eeb
@atodorov
Build creditcoin3-node twice: with & without fast-runtime feature
041c7f6 
all of the existing test jobs are using the -fast-runtime build, however
some new test jobs will require a regular build
@atodorov
Add a matrix test job running creditcoin3-node with different chainspecs
8e02a41 
Note: this CI job is using a non-fast-runtime build of creditcoin3-node!

Allows overriding jest setup via the BLOCKCHAIN_TESTS_GLOBAL_SETUP ENV
variable to minimize the number of dummy config files
@atodorov
Make build-creditcoin-node-fast-runtime depend on build-creditcoin-node
3943305 
and use the same shared-key between the 2 CI jobs in order to better
utilize the existing rustc cache and speed-up overall execution time
@atodorov atodorov force-pushed the testing/add-integration-tests-for-blockchain branch from 6c23889 to 3943305 Compare January 16, 2024 16:06
@atodorov
Copy link
Contributor Author

Rebased onto #170 and the previously failing integration-test-chainspec-testnet is now passing:
/~https://github.com/gluwa/creditcoin3/actions/runs/7544313013/job/20537656625?pr=171

@atodorov atodorov mentioned this pull request Jan 16, 2024
Merged
9 tasks
@atodorov atodorov mentioned this pull request Jan 16, 2024
Merged
9 tasks
@atodorov atodorov marked this pull request as ready for review January 17, 2024 17:09
@atodorov atodorov merged commit c6eef9f into dev Jan 18, 2024
29 of 30 checks passed
@atodorov atodorov deleted the testing/add-integration-tests-for-blockchain branch January 18, 2024 17:08
@atodorov atodorov changed the title Add integration tests for blockchain & check block time from chainspec CSUB-1010: Add integration tests for blockchain & check block time from chainspec Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyfrederick zacharyfrederick zacharyfrederick approved these changes

@pLabarta pLabarta Awaiting requested review from pLabarta

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

@frankli-dev frankli-dev Awaiting requested review from frankli-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atodorov @zacharyfrederick @pLabarta