Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tracking service to portalicious #6539

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Feb 21, 2025

AB#33897

Describe your changes

Following up on the work done by @elwinschmitz in #6535 - I decided to refactor some of the conditions into a separate service, similarly to what was done with the authservice, so that the application as a whole is unaware (and does not care) whether Matomo is enabled / configured for the current instance.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6539.westeurope.5.azurestaticapps.net

@aberonni aberonni added the chore Something that does not affect the end user label Feb 21, 2025
@Copilot Copilot bot review requested due to automatic review settings February 21, 2025 15:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • interfaces/Portalicious/src/app/pages/privacy/privacy.page.html: Language not supported
  • interfaces/Portalicious/src/app/app.config.ts: Evaluated as low risk
Comments suppressed due to low confidence (1)

interfaces/Portalicious/src/app/services/tracking.service.ts:15

  • The function IS_MATOMO_ENABLED should be a method of the TrackingService class to ensure it always returns the correct state based on the current environment variables.
const IS_MATOMO_ENABLED = () =>
@aberonni aberonni merged commit de4d4b9 into main Feb 25, 2025
5 checks passed
@aberonni aberonni deleted the aberonni/add-tracking-service branch February 25, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants