Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Matomo-client for tracking default metrics #6535

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

elwinschmitz
Copy link
Member

@elwinschmitz elwinschmitz commented Feb 19, 2025

AB#33700

Describe your changes

  • Load the Matomo-client only when necessary
  • Include all the necessary deployment-configuration
  • Limit all features that would require cookies/privacy-notices, etc.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Preview deployment

https://lively-river-04adce503-6535.westeurope.5.azurestaticapps.net

@elwinschmitz elwinschmitz added the enhancement New feature or request that affects our end users label Feb 19, 2025
@elwinschmitz elwinschmitz marked this pull request as ready for review February 20, 2025 09:50
@elwinschmitz elwinschmitz force-pushed the elwin/feat-matomo-tracking branch from ac83c7b to 7fdd931 Compare February 20, 2025 10:03
@elwinschmitz elwinschmitz marked this pull request as draft February 20, 2025 10:20
@elwinschmitz elwinschmitz force-pushed the elwin/feat-matomo-tracking branch from 7fdd931 to 9cf3c32 Compare February 20, 2025 12:00
@elwinschmitz elwinschmitz marked this pull request as ready for review February 20, 2025 12:28
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some small things that I'd like to refactor - but I'll do that in a separate PR because the implementation here looks very solid and thorough (I especially like the attention to detail in the .mjs files). So I'm merging as-is so hopefully we can tracking data and in the meantime do the refactor separately. (Why refactor? This question will be answered in the new PR).

@elwinschmitz elwinschmitz merged commit 1aeff3c into main Feb 21, 2025
7 checks passed
@elwinschmitz elwinschmitz deleted the elwin/feat-matomo-tracking branch February 21, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request that affects our end users
Development

Successfully merging this pull request may close these issues.

2 participants