Allow non-required properties in the portal & change import registrat… #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenGeo
added
enhancement
4 tasks
Base automatically changed from
fix.k6-tests
to
refactor-registration-data-fix-existing-api-tests
November 5, 2024 09:58
RubenGeo
force-pushed
the
refactor-registration-data-fix-existing-api-tests
branch
2 times, most recently
from
aae853d to
f49f058
Compare
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
a1e8ff1 to
5e6fefe
Compare
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
5e6fefe to
f00d8c6
Compare
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
f00d8c6 to
d248e7f
Compare
jannisvisser
requested changes
Nov 6, 2024
...es/Portal/src/app/program/edit-person-affected-popup/edit-person-affected-popup.component.ts
Show resolved
Hide resolved
interfaces/Portal/src/app/components/update-property-item/update-property-item.component.ts
Show resolved
Hide resolved
e2e/tests/121-Portal/MakeNewPayment/Safaricom/MakeFailedPaymentSafaricom.spec.ts
Outdated
Show resolved
Hide resolved
e2e/tests/121-Portal/EditInfoPersonAffected/UpdatePhoneNumberInvalid.spec.ts
Show resolved
Hide resolved
.../Portal/src/app/program/edit-person-affected-popup/edit-person-affected-popup.component.html
Show resolved
Hide resolved
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
268549b to
cfa1f6f
Compare
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
e2b8eff to
cfa1f6f
Compare
RubenGeo
force-pushed
the
refactor-registration-data-unrequired-attributes-portal
branch
from
cfa1f6f to
e9f7697
Compare
jannisvisser
approved these changes
Nov 6, 2024
jannisvisser
merged commit 0fd470f
into
refactor-registration-data-fix-existing-api-tests
5 of 6 checks passed
jannisvisser
deleted the
refactor-registration-data-unrequired-attributes-portal
branch
jannisvisser
added a commit
that referenced
this pull request
Nov 6, 2024
* WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl>
RubenGeo
pushed a commit
that referenced
this pull request
Nov 7, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl>
RubenGeo
pushed a commit
that referenced
this pull request
Nov 7, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import
RubenGeo
pushed a commit
that referenced
this pull request
Nov 7, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes
aberonni
pushed a commit
that referenced
this pull request
Nov 8, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes
RubenGeo
pushed a commit
that referenced
this pull request
Nov 8, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 11, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 19, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 19, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 19, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 20, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 20, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 20, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 20, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 21, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 21, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 21, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 25, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 25, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 27, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
aberonni
pushed a commit
that referenced
this pull request
Nov 28, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 29, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Nov 29, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
pushed a commit
that referenced
this pull request
Dec 2, 2024
Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments
RubenGeo
added a commit
that referenced
this pull request
Dec 2, 2024
* Refactor registration data and attributes Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments * portalicious: fix remaining endpoints (#6196) AB#31660 --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#30835
Describe your changes
Non-required properties in edit PA popup
other changes
Checklist before requesting a review