fix: make seed mock script work again #6003

jannisvisser · 2024-10-30T10:58:27Z

Describe your changes

make seed mock script work again

Checklist before requesting a review

I have performed a self-review of my code
I have added tests wherever relevant
I have made sure that all automated checks pass before requesting a review
I do not need any deviation from our PR guidelines

RubenGeo · 2024-10-30T12:35:40Z

services/121-service/src/migration/1708330965061-migrate-data-changes-to-event.ts

@@ -31,7 +31,6 @@ export class MigrateDataChangesToEvent1708330965061
    await queryRunner.query(
      `DROP INDEX "121-service"."IDX_5c7356500932acbd5f76a787ce"`,
    );
-    console.time('migrateData');


* fix: make seed mock script work again * fix: revert to abbreviated sequence name

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl>

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl>

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes

Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments

* Refactor registration data and attributes Excel FSP: multiple per program (#5848) * Excel FSP: multiple per program * Program registration attribute portal (#5858) * Frontend alligning to new registration attribute & fsp config change Renamed portal models according to new data structure, registration attribtes & new fsp conig Added missing import Check voucher support with fspName instead of label * Styling changes --------- Co-authored-by: Ruben <vandervalk@geoit.nl> * Fix.excel setup (#5970) * fix: get match column correctly AB#30281 * fix: lingering case of StatusEnum AB#30281 * fix: do not duplicate response rows with multiple fspConfigs * fix: api-test AB#30281 * fix: fix and unskip api-test on get fsp instructions AB#30281 * fix: api-test on snapshot AB#30281 * feat: return separate template file per fsp config * fix: snapshot template api test * chore: remove hasReconciliation * chore: split off interface * fix: resolve comments --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> Validate fsp config and required attributes for Registration data refactor (#5860) * AB#30474 Validate fsp config and required attributes WIP * AB#30474 & AB#30781 Validate registration with program registration attribute refactor * Migrate refactored registration data and program attributes (#5977) Migrations refactor registration data Co-authored-by: Ruben <vandervalk@geoit.nl> * Select the right kind of type while migrating program questions * Changes based on comments on the new validation of registrations * Expect required fsp attributes to be filled during payment * chore: rm unused methods / unskip tests / typos (#6004) --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> fix: make seed mock script work again (#6003) * fix: make seed mock script work again * fix: revert to abbreviated sequence name test: api-tests on update chosen fsp AB#31025 (#6006) Fix.test data (#6015) * fix: api-test excel * fix: make test data work * fix: calculate totalmultiplierSum in dryRun case * fix: import of boolean attribute Program fsp configs endpoints (#5989) * Some initial refactor and draft code Add code framework for endpoints Get endpoint implementation done WIP implement post endpoint * Manage fsp config enpoints * Comments jannis manage program fsp config --------- Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com> Co-authored-by: Ruben <vandervalk@geoit.nl> fix api & unit & e2e tests (#6010) * WIP: fix api & unit tests * Fixed playwright tests & typechecks after registration data refactor * fix: getProgramWithManyAttributes + drop persistence (#6016) Fixed playwright tests & typechecks after registration data refactor fix: getProgramWithManyAttributes + drop persistence fix: other k6 tests chore: update import csv endpoint path + rm remnants of import-as-invited test: add k6 test for import 1000 registrations temp change GA k6 test file to import1000registrations to test length typo fix: small performance increase + set allowed duration + switch gh action test back to default one Co-authored-by: Ruben <vandervalk@geoit.nl> Enabled portal e2e tests again * Fix bug in cbe query & added api test (#6031) Co-authored-by: Ruben <vandervalk@geoit.nl> * Api test for programFspConfigName is not equal to the fsp name (#6030) * Api test for programFspConfigName is not equal to the fsp name * Api test for programFspConfigName is not equal to the fsp name * chore: update snapshot filename --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> * Refactor the code validateRequiredFinancialServiceProviderConfiguration (#6029) Co-authored-by: Ruben <vandervalk@geoit.nl> * Remove permissions for refactor registration data (#6034) Co-authored-by: Ruben <vandervalk@geoit.nl> * Refactor registration data processing comments on AB#30189 * Made api test less twitchy * Out of date tests * Allow non-required properties in the portal & change import registrat… (#6024) * Allow non-required properties in the portal & change import registrations url * Refactor registration data comment on non-required properties in portal --------- Co-authored-by: Ruben <vandervalk@geoit.nl> --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: jannisvisser <jannisvisser@redcross.nl> lint fix import Fix safaricom attributes Chore.cleanup code (#6036) * fix: rm lingering cases of program-question/custom-attribute/etc * chore: more cleanup * Fix.permission update fsp (#6041) * fix: check specifically on update-fsp permission in patch endpoint * test: api-test on bulk update chosen fsp * fix: process PR comments * portalicious: fix remaining endpoints (#6196) AB#31660 --------- Co-authored-by: Ruben <vandervalk@geoit.nl> Co-authored-by: Domenico Gemoli <dgemoli@redcross.nl>

jannisvisser had a problem deploying to test October 30, 2024 10:58 — with GitHub Actions Failure

jannisvisser added the Refactor registration data label Oct 30, 2024

jannisvisser requested a review from RubenGeo October 30, 2024 12:29

Base automatically changed from program-registration-attribute-validate-fsp-config to feat.refactor-registration-data October 30, 2024 12:36

RubenGeo approved these changes Oct 30, 2024

View reviewed changes

fix: make seed mock script work again

350ad9d

jannisvisser force-pushed the fix.seed-mock-nlrc-scripts branch from 30bccff to 350ad9d Compare October 30, 2024 12:39

jannisvisser had a problem deploying to test October 30, 2024 12:39 — with GitHub Actions Failure

fix: revert to abbreviated sequence name

b4a9f1c

jannisvisser had a problem deploying to test October 30, 2024 12:48 — with GitHub Actions Failure

jannisvisser merged commit dd35603 into feat.refactor-registration-data Oct 30, 2024
0 of 5 checks passed

jannisvisser deleted the fix.seed-mock-nlrc-scripts branch October 30, 2024 13:53

RubenGeo pushed a commit that referenced this pull request Oct 31, 2024

fix: make seed mock script work again (#6003)

62a6df1

* fix: make seed mock script work again * fix: revert to abbreviated sequence name

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: make seed mock script work again #6003

fix: make seed mock script work again #6003

jannisvisser commented Oct 30, 2024 •

edited

Loading

RubenGeo Oct 30, 2024

fix: make seed mock script work again #6003

fix: make seed mock script work again #6003

Conversation

jannisvisser commented Oct 30, 2024 • edited Loading

Describe your changes

Checklist before requesting a review

RubenGeo Oct 30, 2024

Choose a reason for hiding this comment

jannisvisser commented Oct 30, 2024 •

edited

Loading