-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #110
Merged
Merged
V2 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 5beb828 in 1 minute and 0 seconds
More details
- Looked at
809
lines of code in20
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. src/api/resources/group/client/Client.ts:43
- Draft comment:
Avoid using default empty object forrequest
parameter. It may lead to runtime errors sinceCreateGroupRequest
has required fields. - Reason this comment was not posted:
Comment looked like it was already resolved.
2. src/api/resources/memory/client/Client.ts:1425
- Draft comment:
Avoid using default empty object forrequest
parameter. It may lead to runtime errors ifAddMemoryRequest
has required fields. - Reason this comment was not posted:
Comment was on unchanged code.
3. src/api/resources/graph/client/requests/GraphSearchQuery.ts:15
- Draft comment:
Ensure the comment starts with a capital letter for consistency and clarity.
/** One of user_id or group_id must be provided */
- Reason this comment was not posted:
Comment did not seem useful.
4. src/api/resources/graph/client/requests/GraphSearchQuery.ts:30
- Draft comment:
Ensure the comment starts with a capital letter for consistency and clarity.
/** One of user_id or group_id must be provided */
- Reason this comment was not posted:
Marked as duplicate.
5. src/api/resources/group/client/requests/CreateGroupRequest.ts:15
- Draft comment:
Ensure the comment is concise and clear.
/** User IDs */
- Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_RJg3yJKG82jVHcx0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update version to 2.2.0 and enhance API with new fields and mandatory parameters in various request and response types.
2.2.0
inpackage.json
and multipleClient.ts
files.CreateGroupRequest
now requiresgroupId
.AddMemoryRequest
includes optionalreturnContext
.ApidataAddMemoryResponse
added with optionalcontext
field.User
type now includesfactRatingInstruction
.CreateGroupRequest
andAddMemoryRequest
to reflect new fields.ApidataAddMemoryResponse
.Graph.ts
andGraphSearchQuery.ts
.This description was created by
for 5beb828. It will automatically update as commits are pushed.